# HG changeset patch # User js # Date 1168980630 28800 # Node ID 9e76e87c857e8287448c1f5bf412e2f4adcf1e95 # Parent 052f2149341932afcb080da40a5acc8a0c36cb1f [svn] One more. Seems like one meant id3v1, not id3v2 for the 30 char limit. diff -r 052f21493419 -r 9e76e87c857e ChangeLog --- a/ChangeLog Tue Jan 16 12:47:04 2007 -0800 +++ b/ChangeLog Tue Jan 16 12:50:30 2007 -0800 @@ -1,3 +1,11 @@ +2007-01-16 20:47:04 +0000 Jonathan Schleifer + revision [968] + I committed too fast, there was even more. + trunk/src/tta/aud-tta.c | 12 +++++------- + trunk/src/tta/ttaid3tag.h | 9 ++++++--- + 2 files changed, 11 insertions(+), 10 deletions(-) + + 2007-01-16 20:41:40 +0000 Jonathan Schleifer revision [966] Fix of possible buffer overflow. diff -r 052f21493419 -r 9e76e87c857e src/tta/aud-tta.c --- a/src/tta/aud-tta.c Tue Jan 16 12:47:04 2007 -0800 +++ b/src/tta/aud-tta.c Tue Jan 16 12:50:30 2007 -0800 @@ -954,8 +954,10 @@ // comment str = tta_input_id3_get_string (tag, ID3_FRAME_COMMENT); - if(str) - strncpy(ttainfo->id3v2.comment, str, 30); + if(str) { + strncpy(ttainfo->id3v2.comment, str, MAX_LINE); + strncpy(ttainfo->id3v1.comment, str, 30); + } free(str); str = NULL;