# HG changeset patch # User yaz # Date 1160712825 25200 # Node ID fadf346ddde387b11b50f7610eb12fce7a6858bf # Parent 6e1002ea4ded3a85577ff555ec5d644aa70bd5c8 [svn] - pls doesn't go along with PLAYLIST_LOCK in playlist_save(). diff -r 6e1002ea4ded -r fadf346ddde3 ChangeLog --- a/ChangeLog Thu Oct 12 09:05:01 2006 -0700 +++ b/ChangeLog Thu Oct 12 21:13:45 2006 -0700 @@ -1,3 +1,12 @@ +2006-10-12 16:05:01 +0000 William Pitcock + revision [182] + - some seek code (can't be implemented right now though) + - change `return 1' to `return NULL' in decode_thread(). + + trunk/src/alac/plugin.c | 23 ++++++++++++++++++++--- + 1 file changed, 20 insertions(+), 3 deletions(-) + + 2006-10-12 13:21:12 +0000 Yoshiki Yazawa revision [180] - fix for lock contention on saving m3u. locking playlist has been done in playlist_save(). diff -r 6e1002ea4ded -r fadf346ddde3 src/m3u/m3u.c --- a/src/m3u/m3u.c Thu Oct 12 09:05:01 2006 -0700 +++ b/src/m3u/m3u.c Thu Oct 12 21:13:45 2006 -0700 @@ -153,6 +153,8 @@ if (cfg.use_pl_metadata) vfs_fprintf(file, "#EXTM3U\n"); + PLAYLIST_LOCK(); + for (node = playlist_get(); node; node = g_list_next(node)) { PlaylistEntry *entry = PLAYLIST_ENTRY(node->data); @@ -177,6 +179,8 @@ vfs_fprintf(file, "%s\n", entry->filename); } + PLAYLIST_UNLOCK(); + vfs_fclose(file); } diff -r 6e1002ea4ded -r fadf346ddde3 src/xspf/xspf.c --- a/src/xspf/xspf.c Thu Oct 12 09:05:01 2006 -0700 +++ b/src/xspf/xspf.c Thu Oct 12 21:13:45 2006 -0700 @@ -228,6 +228,8 @@ tracklist = xmlNewNode(NULL, "trackList"); xmlAddChild(rootnode, tracklist); + PLAYLIST_LOCK(); + for (node = playlist_get(); node != NULL; node = g_list_next(node)) { PlaylistEntry *entry = PLAYLIST_ENTRY(node->data); @@ -383,6 +385,8 @@ } + PLAYLIST_UNLOCK(); + xmlSaveFormatFile(filename, doc, 1); xmlFreeDoc(doc); }