changeset 108:0eb1e99b7748 trunk

[svn] - move prefswin_page_destroy(cfgdlg) to before the plugin logs out of last.fm; otherwise the prefswin_page handle isn't always removed. Reported on IRC by Tim Yamin <plasmaroo -at- gentoo.org>
author nenolod
date Tue, 24 Oct 2006 18:15:53 -0700
parents ef4bc8441d10
children 38ce41606f10
files ChangeLog src/scrobbler/xmms_scrobbler.c
diffstat 2 files changed, 11 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Tue Oct 24 01:44:06 2006 -0700
+++ b/ChangeLog	Tue Oct 24 18:15:53 2006 -0700
@@ -1,3 +1,12 @@
+2006-10-24 08:44:06 +0000  William Pitcock <nenolod@nenolod.net>
+  revision [214]
+  - 1.2.2 release
+  
+  trunk/NEWS         |    7 +++++++
+  trunk/configure.ac |    2 +-
+  2 files changed, 8 insertions(+), 1 deletion(-)
+
+
 2006-10-24 03:06:39 +0000  William Pitcock <nenolod@nenolod.net>
   revision [212]
   - bleah fix FLAC check
--- a/src/scrobbler/xmms_scrobbler.c	Tue Oct 24 01:44:06 2006 -0700
+++ b/src/scrobbler/xmms_scrobbler.c	Tue Oct 24 18:15:53 2006 -0700
@@ -101,6 +101,8 @@
     g_free (xmms_scrobbler.description);
     xmms_scrobbler.description = NULL;
 
+        prefswin_page_destroy(cfgdlg);
+
 	if (!going)
 		return;
 	pdebug("about to lock mutex", DEBUG);
@@ -113,8 +115,6 @@
 
 	g_thread_join(pt_handshake);
 
-        prefswin_page_destroy(cfgdlg);
-
 	sc_cleaner();
 }