changeset 239:e45005422574 trunk

[svn] FD leak fix by TiCPU, submitted in #audacious.
author chainsaw
date Mon, 13 Nov 2006 04:35:19 -0800
parents 74f307156fa5
children 59d793da5395
files ChangeLog src/cue/cuesheet.c
diffstat 2 files changed, 11 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Sat Nov 11 10:56:43 2006 -0800
+++ b/ChangeLog	Mon Nov 13 04:35:19 2006 -0800
@@ -1,3 +1,11 @@
+2006-11-11 18:56:43 +0000  William Pitcock <nenolod@nenolod.net>
+  revision [490]
+  - fix a potential segfault on x86
+  
+  trunk/src/paranormal/wave.c |    4 ++--
+  1 file changed, 2 insertions(+), 2 deletions(-)
+
+
 2006-11-07 10:11:05 +0000  William Pitcock <nenolod@nenolod.net>
   revision [488]
   - a slightly better way of doing things here
--- a/src/cue/cuesheet.c	Sat Nov 11 10:56:43 2006 -0800
+++ b/src/cue/cuesheet.c	Mon Nov 13 04:35:19 2006 -0800
@@ -370,8 +370,10 @@
 		gint p;
 		gint q;
 
-		if (vfs_fgets(line, MAX_CUE_LINE_LENGTH+1, file) == NULL)
+		if (vfs_fgets(line, MAX_CUE_LINE_LENGTH+1, file) == NULL) {
+			vfs_fclose(file);
 			return;
+                }
 
 		for (p = 0; line[p] && isspace((int) line[p]); p++);
 		if (!line[p])