# HG changeset patch
# User nenolod
# Date 1169718771 28800
# Node ID 4daf4fa409e06aa7036ed4c1d229e1acb53b52c1
# Parent  9b7b11176d4e9e008b3b7159445f534c7bff5f30
[svn] - make a note that hashtable collisions in the plugin matrix are not
  only possible, but happening, and have strange side effects.

diff -r 9b7b11176d4e -r 4daf4fa409e0 ChangeLog
--- a/ChangeLog	Wed Jan 24 18:40:07 2007 -0800
+++ b/ChangeLog	Thu Jan 25 01:52:51 2007 -0800
@@ -1,3 +1,11 @@
+2007-01-25 02:40:07 +0000  Yoshiki Yazawa <yaz@cc.rim.or.jp>
+  revision [3808]
+  - should not pass null fd to input plugins.
+  
+  trunk/src/audacious/input.c |    3 +++
+  1 file changed, 3 insertions(+)
+
+
 2007-01-24 23:15:46 +0000  Derek Pomery <nemo@m8y.org>
   revision [3806]
   Strip 0xFEFF 
diff -r 9b7b11176d4e -r 4daf4fa409e0 src/audacious/pluginenum.c
--- a/src/audacious/pluginenum.c	Wed Jan 24 18:40:07 2007 -0800
+++ b/src/audacious/pluginenum.c	Thu Jan 25 01:52:51 2007 -0800
@@ -277,6 +277,12 @@
         return;
     }
 
+    /*
+     * FIXME: this collides in many cases. this is really bad.
+     * i have no idea why we use a hashtable here, there is no point, when
+     * a list of enabled plugins would realistically offer the same 
+     * scalability.                                       - nenolod
+     */
     plugin_matrix = g_hash_table_new_full(g_str_hash, g_int_equal, g_free,
                                           NULL);