# HG changeset patch # User giacomo # Date 1174098114 25200 # Node ID 85acf3f98ed057270651b283d8656c508bfde863 # Parent 4c069ce6105344fe85cd147eef3017021d7dc09a [svn] - prevent skin list overlap when it's populated for the first time and user quickly switchs to other tabs in the prefswin diff -r 4c069ce61053 -r 85acf3f98ed0 ChangeLog --- a/ChangeLog Fri Mar 16 19:07:19 2007 -0700 +++ b/ChangeLog Fri Mar 16 19:21:54 2007 -0700 @@ -1,3 +1,11 @@ +2007-03-17 02:07:19 +0000 William Pitcock + revision [4272] + - performance is better without r4270. + + trunk/src/audacious/ui_jumptotrack.c | 2 -- + 1 file changed, 2 deletions(-) + + 2007-03-17 01:44:03 +0000 William Pitcock revision [4270] - run gtkevents while populating the list. diff -r 4c069ce61053 -r 85acf3f98ed0 src/audacious/build_stamp.c --- a/src/audacious/build_stamp.c Fri Mar 16 19:07:19 2007 -0700 +++ b/src/audacious/build_stamp.c Fri Mar 16 19:21:54 2007 -0700 @@ -1,2 +1,2 @@ #include -const gchar *svn_stamp = "20070317-4270"; +const gchar *svn_stamp = "20070317-4272"; diff -r 4c069ce61053 -r 85acf3f98ed0 src/audacious/ui_preferences.c --- a/src/audacious/ui_preferences.c Fri Mar 16 19:07:19 2007 -0700 +++ b/src/audacious/ui_preferences.c Fri Mar 16 19:21:54 2007 -0700 @@ -1857,7 +1857,6 @@ xml = prefswin_get_xml(); widget = glade_xml_get_widget(xml, "skin_refresh_button"); skin_view_realize(treeview); - skin_view_update(treeview, GTK_WIDGET(widget)); return TRUE; } @@ -2681,7 +2680,22 @@ void show_prefs_window(void) { + static gboolean skinlist_filled = FALSE; + gtk_widget_show(prefswin); + + if ( !skinlist_filled ) + { + GladeXML *xml; + GtkWidget *widget, *widget2; + + xml = prefswin_get_xml(); + + widget = glade_xml_get_widget(xml, "skin_view"); + widget2 = glade_xml_get_widget(xml, "skin_refresh_button"); + skin_view_update(GTK_TREE_VIEW(widget), GTK_WIDGET(widget2)); + skinlist_filled = TRUE; + } } static void