# HG changeset patch # User chainsaw # Date 1133626634 28800 # Node ID 95f7737919b1288512dd23800f1e59c71b6f3d63 # Parent acae8fa925c365f6bbae9022f154071787469681 [svn] Avoid discarding pointer type qualifiers by not using the result of gtk_entry_get_text directly. diff -r acae8fa925c3 -r 95f7737919b1 Plugins/General/song_change/song_change.c --- a/Plugins/General/song_change/song_change.c Fri Dec 02 15:33:58 2005 -0800 +++ b/Plugins/General/song_change/song_change.c Sat Dec 03 08:17:14 2005 -0800 @@ -108,15 +108,18 @@ char *cmd, *cmd_after, *cmd_end; ConfigFile *cfgfile = xmms_cfg_open_default_file(); - cmd = gtk_entry_get_text(GTK_ENTRY(cmd_entry)); - cmd_after = gtk_entry_get_text(GTK_ENTRY(cmd_after_entry)); - cmd_end = gtk_entry_get_text(GTK_ENTRY(cmd_end_entry)); + cmd = g_strdup(gtk_entry_get_text(GTK_ENTRY(cmd_entry))); + cmd_after = g_strdup(gtk_entry_get_text(GTK_ENTRY(cmd_after_entry))); + cmd_end = g_strdup(gtk_entry_get_text(GTK_ENTRY(cmd_end_entry))); xmms_cfg_write_string(cfgfile, "song_change", "cmd_line", cmd); xmms_cfg_write_string(cfgfile, "song_change", "cmd_line_after", cmd_after); xmms_cfg_write_string(cfgfile, "song_change", "cmd_line_end", cmd_end); xmms_cfg_write_default_file(cfgfile); xmms_cfg_free(cfgfile); + g_free(cmd); + g_free(cmd_after); + g_free(cmd_end); if (timeout_tag) { @@ -200,15 +203,18 @@ { char *cmd, *cmd_after, *cmd_end; - cmd = gtk_entry_get_text(GTK_ENTRY(cmd_entry)); - cmd_after = gtk_entry_get_text(GTK_ENTRY(cmd_after_entry)); - cmd_end = gtk_entry_get_text(GTK_ENTRY(cmd_end_entry)); + cmd = g_strdup(gtk_entry_get_text(GTK_ENTRY(cmd_entry))); + cmd_after = g_strdup(gtk_entry_get_text(GTK_ENTRY(cmd_after_entry))); + cmd_end = g_strdup(gtk_entry_get_text(GTK_ENTRY(cmd_end_entry))); if (check_command(cmd) < 0 || check_command(cmd_after) < 0 || check_command(cmd_end) < 0) warn_user(); else save_and_close(NULL, NULL); + g_free(cmd); + g_free(cmd_after); + g_free(cmd_end); }