# HG changeset patch # User nenolod # Date 1176229646 25200 # Node ID e9b379528fbc0a36bf47a1034f55f7babd9b46e5 # Parent 84a10fce92a1889f418011954871f0cca1f51b79 [svn] - playlist_get_length_nolock() -> playlist_get_length(), no need for locking here. diff -r 84a10fce92a1 -r e9b379528fbc ChangeLog --- a/ChangeLog Tue Apr 10 11:25:39 2007 -0700 +++ b/ChangeLog Tue Apr 10 11:27:26 2007 -0700 @@ -1,3 +1,11 @@ +2007-04-10 18:25:39 +0000 William Pitcock + revision [4366] + - playlist_set_info() does not change the playlist and shouldn't block + + trunk/src/audacious/playlist.c | 8 -------- + 1 file changed, 8 deletions(-) + + 2007-04-10 18:20:21 +0000 William Pitcock revision [4364] - tuple operations do not change the structure of the playlist and diff -r 84a10fce92a1 -r e9b379528fbc src/audacious/build_stamp.c --- a/src/audacious/build_stamp.c Tue Apr 10 11:25:39 2007 -0700 +++ b/src/audacious/build_stamp.c Tue Apr 10 11:27:26 2007 -0700 @@ -1,2 +1,2 @@ #include -const gchar *svn_stamp = "20070410-4364"; +const gchar *svn_stamp = "20070410-4366"; diff -r 84a10fce92a1 -r e9b379528fbc src/audacious/playlist.c --- a/src/audacious/playlist.c Tue Apr 10 11:25:39 2007 -0700 +++ b/src/audacious/playlist.c Tue Apr 10 11:27:26 2007 -0700 @@ -1112,7 +1112,7 @@ return; } - bottom = MAX(0, playlist_get_length_nolock(playlist) - + bottom = MAX(0, playlist_get_length(playlist) - playlistwin_list->pl_num_visible); row = CLAMP(pos - playlistwin_list->pl_num_visible / 2, 0, bottom); PLAYLIST_UNLOCK(playlist->mutex); @@ -1491,18 +1491,6 @@ } gint -playlist_get_length(Playlist *playlist) -{ - gint retval; - - PLAYLIST_LOCK(playlist->mutex); - retval = playlist_get_length_nolock(playlist); - PLAYLIST_UNLOCK(playlist->mutex); - - return retval; -} - -gint playlist_queue_get_length(Playlist *playlist) { gint length; @@ -1515,7 +1503,7 @@ } gint -playlist_get_length_nolock(Playlist *playlist) +playlist_get_length(Playlist *playlist) { return g_list_length(playlist->entries); }