# HG changeset patch # User Matti Hamalainen # Date 1209255847 -10800 # Node ID f2271d78e07ef7265d7afc99fef9699ed81e56ce # Parent 6e412073cf28ce680b39779bef0c6eec13227d6d Handling of remote DBus PlaylistAdd method was incorrect, causing a segfault. Dbus marshaller does not send a GList of strings of filenames to be added to audacious_rc_playlist_add(), but the list element data. Fixed. diff -r 6e412073cf28 -r f2271d78e07e src/audacious/dbus.c --- a/src/audacious/dbus.c Wed Apr 23 22:20:35 2008 +0200 +++ b/src/audacious/dbus.c Sun Apr 27 03:24:07 2008 +0300 @@ -945,13 +945,8 @@ return TRUE; } -static void call_playlist_add_url(GList *list, gpointer *data) { - playlist_add_url(playlist_get_active(), list->data); -} - gboolean audacious_rc_playlist_add(RemoteObject *obj, gpointer list, GError **error) { - g_list_foreach((GList *)list, (GFunc)call_playlist_add_url, NULL); - return TRUE; + return playlist_add_url(playlist_get_active(), (gchar *) list) > 0; } gboolean audacious_rc_playlist_enqueue_to_temp(RemoteObject *obj, gchar *url, GError **error) {