changeset 1193:03414b9d2507 trunk

[svn] filesize must be cached, otherwise lookup loop will crash.
author yaz
date Tue, 13 Jun 2006 08:36:56 -0700
parents 62726fb1cb3b
children 0c0a5ff7b20b
files ChangeLog audacious/util.c
diffstat 2 files changed, 12 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Tue Jun 13 01:59:28 2006 -0700
+++ b/ChangeLog	Tue Jun 13 08:36:56 2006 -0700
@@ -1,3 +1,13 @@
+2006-06-13 08:59:28 +0000  William Pitcock <nenolod@nenolod.net>
+  revision [1294]
+  - fix potential crashing on malformed ID3v2 tags
+  
+
+  Changes:        Modified:
+  +4 -0           trunk/Plugins/General/scrobbler/tags/id3v2.c  
+  +6 -0           trunk/Plugins/General/scrobbler/tags/unicode.c  
+
+
 2006-06-12 10:25:29 +0000  Tony Vroon <chainsaw@gentoo.org>
   revision [1292]
   Updated japanese translation by dai, closes bug #384.
--- a/audacious/util.c	Tue Jun 13 01:59:28 2006 -0700
+++ b/audacious/util.c	Tue Jun 13 08:36:56 2006 -0700
@@ -403,7 +403,8 @@
     static gchar *open_buffer = NULL;
     gchar *ret_buffer = NULL;
     gint found_section = 0, len = 0;
-    gsize filesize, off = 0;
+    static gsize filesize = 0;
+    gsize off = 0;
     gchar *outbuf;
     unsigned char x[] = { 0xff, 0xfe, 0x00 };
     guint counter;