changeset 2345:0fb47429ad7e trunk

[svn] - in mainwin_real_show, do not return if a nullmask doesn't exist
author giacomo
date Tue, 16 Jan 2007 04:18:58 -0800
parents 3196a09a03e5
children 0b98ad8c8b17
files ChangeLog src/audacious/ui_main.c
diffstat 2 files changed, 14 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Mon Jan 15 20:47:50 2007 -0800
+++ b/ChangeLog	Tue Jan 16 04:18:58 2007 -0800
@@ -1,3 +1,12 @@
+2007-01-16 04:47:50 +0000  William Pitcock <nenolod@sacredspiral.co.uk>
+  revision [3698]
+  - fix potential overflow on bigendian (<= is not proper for boundschecking -- duh)
+  
+  trunk/src/audacious/input.c      |    2 +-
+  trunk/src/audacious/vfs_buffer.c |    4 ++--
+  2 files changed, 3 insertions(+), 3 deletions(-)
+
+
 2007-01-16 03:28:19 +0000  William Pitcock <nenolod@sacredspiral.co.uk>
   revision [3696]
   - compare against the uri, not the VFSConstructor class the fd comes from
--- a/src/audacious/ui_main.c	Mon Jan 15 20:47:50 2007 -0800
+++ b/src/audacious/ui_main.c	Tue Jan 16 04:18:58 2007 -0800
@@ -2467,11 +2467,11 @@
 
     gtk_widget_show_all(mainwin);
 
-    if (!nullmask)
-        return;
-
-    g_object_unref(nullmask);
-    nullmask = NULL;
+    if (nullmask)
+    {
+      g_object_unref(nullmask);
+      nullmask = NULL;
+    }
 
     gdk_window_set_hints(mainwin->window, 0, 0,
                          !bmp_active_skin->properties.mainwin_width ? PLAYER_WIDTH :