Mercurial > audlegacy
changeset 2624:840fb578a834 trunk
[svn] - [security, backport to 1.3] fix improper comparisons of hashtables used by the plugin loader.
| author | nenolod |
|---|---|
| date | Fri, 16 Mar 2007 00:25:44 -0700 |
| parents | 0ad10a95ed10 |
| children | c33d545fc024 |
| files | ChangeLog src/audacious/build_stamp.c src/audacious/pluginenum.c |
| diffstat | 3 files changed, 13 insertions(+), 8 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Thu Mar 15 19:25:27 2007 -0700 +++ b/ChangeLog Fri Mar 16 00:25:44 2007 -0700 @@ -1,3 +1,14 @@ +2007-03-16 02:25:27 +0000 William Pitcock <nenolod@sacredspiral.co.uk> + revision [4258] + - plugin reloading. + + trunk/src/audacious/glade/prefswin.glade | 79 ++++++++++++++++++++++++++++++- + trunk/src/audacious/pluginenum.c | 68 ++++++++++++++------------ + trunk/src/audacious/ui_preferences.c | 13 +++++ + trunk/src/audacious/vfs.c | 2 + 4 files changed, 127 insertions(+), 35 deletions(-) + + 2007-03-16 01:44:52 +0000 William Pitcock <nenolod@sacredspiral.co.uk> revision [4256] - due to some bug in buffer management, bump the buffer side of things up to ~40kb instead of 32kb for now.
--- a/src/audacious/build_stamp.c Thu Mar 15 19:25:27 2007 -0700 +++ b/src/audacious/build_stamp.c Fri Mar 16 00:25:44 2007 -0700 @@ -1,2 +1,2 @@ #include <glib.h> -const gchar *svn_stamp = "20070316-4256"; +const gchar *svn_stamp = "20070316-4258";
--- a/src/audacious/pluginenum.c Thu Mar 15 19:25:27 2007 -0700 +++ b/src/audacious/pluginenum.c Fri Mar 16 00:25:44 2007 -0700 @@ -281,13 +281,7 @@ return; } - /* - * FIXME: this collides in many cases. this is really bad. - * i have no idea why we use a hashtable here, there is no point, when - * a list of enabled plugins would realistically offer the same - * scalability. - nenolod - */ - plugin_matrix = g_hash_table_new_full(g_str_hash, g_int_equal, g_free, + plugin_matrix = g_hash_table_new_full(g_str_hash, g_str_equal, g_free, NULL); #ifndef DISABLE_USER_PLUGIN_DIR