Mercurial > emacs
annotate etc/future-bug @ 109748:e2f8226efb99
Fix -Wwrite_strings in general and for Gtk+ specific code.
* callproc.c (synch_process_death): Make const.
(Fcall_process): Make signame const.
* emacs.c (main): Pass char[] to putenv instead of literal.
* floatfns.c (matherr): Use a const char* variable for x->name.
* font.c (font_open_by_name): Make name const.
* font.h (font_open_by_name): Make name const.
* gtkutil.c (get_utf8_string): Always return an allocated string.
Parameter is const.
(create_dialog, xg_create_one_menuitem, create_menus)
(xg_item_label_same_p, xg_update_menu_item): Free result from
get_utf8_string.
(xg_separator_p, xg_item_label_same_p): label is const.
* gtkutil.h: Replace widget_value with struct _widget_value.
(enum button_type, struct _widget_value): Remove and use the one from
keyboard.h.
* keyboard.h (_widget_value): Add defined USE_GTK. Replace Boolean
with unsigned char and XtPointer with void *.
* menu.c (Fx_popup_menu): error_name is const.
* menu.h (w32_menu_show, ns_menu_show, xmenu_show): error parameter
is const char **.
* w32menu.c (w32_menu_show):
* nsmenu.m (ns_menu_show): error parameter is const char **.
* process.h (synch_process_death): Is const char*.
* xmenu.c (Fx_popup_dialog): error_name is const char*.
(xmenu_show): error parameter is const char **. pane_string is const
char *.
(button_names): Is const char *.
(xdialog_show): error_name and pane_string is const.
* xrdb.c (get_system_app): Make path const and use char *p for non-const
char.
* xselect.c (Fx_get_atom_name): Use char empty[] instead of literal "".
* xsmfns.c (NOSPLASH_OPT): Change to char[].
(smc_save_yourself_CB): Do xstrdup on all ->type and ->name for
props. Free them at the end.
* xterm.c (emacs_class): New char[] for EMACS_CLASS.
(xim_open_dpy, xim_initialize, xim_close_dpy): Use emacs_class.
(x_term_init): Use char[] display_opt and name_opt instead of
string literal. file is const char*.
author | Jan D <jan.h.d@swipnet.se> |
---|---|
date | Wed, 11 Aug 2010 14:34:46 +0200 |
parents | 40be809ca221 |
children |
rev | line source |
---|---|
25852 | 1 Date: Tue, 23 Feb 2199 21:03:50 -0600 |
2 From: Karl Fogel <kfogel@floss.cyclic.com> | |
3 To: bug-gnu-emacs@prep.ai.mit.edu | |
4 Subject: M-x search-backward-in-time broken... | |
5 X-Windows: you'll envy the dead. | |
6 | |
7 In GNU Emacs 51.70.4 (i9986-unknown-linux-gnu, X toolkit) of Sat Feb 20 2199 on floss | |
8 configured using `configure --with-x-toolkit=yes' | |
9 | |
10 The `search-backward-in-time' function appears to be broken in | |
49600
23a1cea22d13
Trailing whitespace deleted.
Juanma Barranquero <lekktu@gmail.com>
parents:
25852
diff
changeset
|
11 Emacs 51.70. |
25852 | 12 |
13 Unfortunately, I can never seem to start the debugger early | |
14 enough to catch the error as it happens. However I have traced the | |
15 problem through source by eye, and it looks like `time-forward' can't | |
16 handle negative arguments anymore. This is consistent with other | |
17 symptoms: for example, `undo' (which since 51.25 has worked by passing | |
18 a negative arg to `time-forward') is also broken. However, `do' still | |
19 works -- it seems that `time-forward' continues to handle positive | |
20 arguments just fine. | |
21 | |
22 No one here-and-now can figure out how to fix the problem, | |
23 because the code for `time-forward' is so hairy. We're using M-x | |
24 report-future-emacs-bug to request that you folks include more | |
25 comments when you write it (sometime in 2198 as I recall). | |
26 | |
27 Thanks! | |
28 | |
29 -Karl Fogel <kfogel@red-bean.com> | |
30 | |
31 | |
32 P.S. You'll be pleased to know that since (time-forward N) still works | |
33 for N >= 0, we've used it to pre-emptively update configure.in. | |
34 Emacs now configures and builds on every platform that will ever | |
35 be made. It wasn't easy, but at least that's one problem out of | |
36 the way for good. If you'd like the patch, just ask. | |
37 |