Mercurial > emacs

comparison README.imagemagick @ 109861:8e0241dfb81c

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cosmetics, and changing of defconst to defcustom
author Joakim <joakim@localhost.localdomain>
date Mon, 14 Jun 2010 23:27:03 +0200
parents d7a20b755b64
children 62b3728b6678
comparison
equal deleted inserted replaced
109860:c92f5e6103a8 109861:8e0241dfb81c
13 ./configure --with-imagemagick 13 ./configure --with-imagemagick
14 14
15 15
16 16
17 * TODO 17 * TODO
18 ** complete documentation drafts below 18 #B _ complete documentation drafts below
19 19
20 ** fix inconsistencys with spelling of imagemagick in the src 20 #B X fix inconsistencys with spelling of imagemagick in the src
21 ** report number of images in image bundle types somehow 21 #B X report number of images in image bundle types somehow
22 ** probably add pdf to inhibited types 22 Works like for "gif" support. Thanks to Juri Linkov.
23 ** inhibit types is defconst should probably be defcustom 23 #B X probably add pdf to inhibited types
24 ** decide what to do with some uncommitted imagemagick support 24 #B X inhibit types is defconst should probably be defcustom
25 #B _ decide what to do with some uncommitted imagemagick support
25 functions for image size etc. 26 functions for image size etc.
26 ** Test with more systems 27 #B _ Test with more systems
27 Tested on Fedora 12 so far, and the libmagick that ships with it. 28 Tested on Fedora 12 so far, and the libmagick that ships with it.
28 Ubuntu 8.04 was also tested, but it seems it ships a broken ImageMagick. 29 Ubuntu 8.04 was also tested, but it seems it ships a broken ImageMagick.
29 Also need some way to handle render methods that only work on newer ImageMagicks 30 #B X Also need some way to handle render methods that only work on newer ImageMagicks
31 Is handled by configure now
32
33 * Some nits from Stefan Monnier
34 I just took a quick look at the code and I see the following nits to fix:
35 #B _ obviously a merge will have to come with a good ChangeLog.
36 #B X also the merge will need to come with documentation. Maybe not in the
37 Texinfo form yet, but at least in the etc/NEWS with enough info that
38 describes the `scale' and other such arguments that someone can start
39 using them.
40 #B X the README talks about naming inconsistencies, I think these should be
41 fixed before a first commit (should be straightforward).
42
43 #B X the "let" in image.el should not be followed by a line break and the while
44 should be replaced by a dolist.
45
46 #B X the prototype of imagemagick_load_image has some odd indentation in ([[2010.06.14]])
47 its args, not sure what happened.
48 #B X a few lines in the C code break the 80columns limit.
49 #B X please use ANSI style function declarations rather than K&R for new code. ([[2010.06.14]])
50 #B X you can get rid of the prototypes by reordering the code. ([[2010.06.14]])
51 #B X the docstrings in DEFUN should not be indented (they'll display ([[2010.06.14]])
52 weirdly otherwise in C-h f).
53 #B X Some "{" are at the end of a for/if rather than on their own line. ([[2010.06.14]])
54 #B X why use "*( imtypes + i)" rather than "imtypes[i]"? ([[2010.06.14]])
55 #B X some "," lack a space after them. ([[2010.06.14]])
56 #B X several "=" and "==" lack spaces around them. ([[2010.06.14]])
30 57
31 58
32 * NEWS entry 59 * NEWS entry
33 ** ImageMagick support 60 ** ImageMagick support
34 It is now possible to use the Imagemagick library to load many new 61 It is now possible to use the Imagemagick library to load many new
42 69
43 The function (imagemagick-register-types) will enable the imagemagick 70 The function (imagemagick-register-types) will enable the imagemagick
44 support for the extensions in imagemagick-types minus the types listed 71 support for the extensions in imagemagick-types minus the types listed
45 in imagemagick-types-inhibit. 72 in imagemagick-types-inhibit.
46 73
47 imagemagick-types-inhibit has the value '(C HTML HTM TXT) by default. 74 imagemagick-types-inhibit has the value '(C HTML HTM TXT PDF) by default.
48 This means imagemagick will be used also to load jpeg files, if you 75 This means imagemagick will be used also to load jpeg files, if you
49 have both jpeg and imagemagick libraries linked. Add 'JPG to 76 have both jpeg and imagemagick libraries linked. Add 'JPG to
50 imagemagick-types-inhibit if you do not want this. 77 imagemagick-types-inhibit if you do not want this.
51 78
52 Images loaded with imagemagick will support a couple of new display 79 Images loaded with imagemagick will support a couple of new display
53 specifications: 80 specifications:
54 81
55 - scale 82 - :scale takes a geometry string as defined by ImageMagick:
56 - rotation
57 - index
58 83
59 See the ImageMagick manual for information on how these specifications 84 scale%
60 work. 85 scale-x%xscale-y%
86 width
87 xheight
88 widthxheight
89 widthxheight^
90 widthxheight!
91 widthxheight>
92 widthxheight<
93 area@
94 {size}{offset} {size}{+-}x{+-}y
95
96 See the ImageMagick manual for more information.
97
98 - :rotation specifies a rotation angle in degrees.
99
100 - :index specifies which image inside an image bundle file format, such
101 as TIFF or DJVM, to view.
61 102
62 The image-metadata function can be used to retrieve the total number 103 The image-metadata function can be used to retrieve the total number
63 of images in an image bundle, and the :index property can be used to 104 of images in an image bundle. This is simmilar to how GIF files work.
64 show a particular image within the bundle. This is simmilar to how GIF
65 files work.
66
67 105
68 106
69 * Changelog entry 107 * Changelog entry
70 nothing yet 108 2010-06-12 Joakim Verona <joakim@verona.se>
109 * image.c
110 * image.el
111
71 112
72 * Manual entry 113 * Manual entry
73 nothing yet 114 nothing yet, but the NEWS entry could be adapted.