emacs: lisp/ido.el comparison

comparison lisp/ido.el @ 53323:a053c8c470f3

Handle non-readable directories. (ido-decorations): Add 9th element for non-readable directory. (ido-directory-nonreadable): New dynamic var. (ido-set-current-directory): Set it. (ido-read-buffer, ido-file-internal): (ido-read-file-name, ido-read-directory-name): Let-bind it. (ido-file-name-all-completions1): Return empty list for non-readable directory. (ido-exhibit): Print [Not readable] if directory is not readable. (ido-expand-directory): New defun (based on tiny fix from Karl Chen). (ido-read-file-name, ido-file-internal, ido-read-directory-name): Use it.

author	Kim F. Storm <storm@cua.dk>
date	Sat, 27 Dec 2003 21:56:51 +0000
parents	77088b91def1
children	4b85f31aef7c

comparison

equal deleted inserted replaced

-:a8f0b8194a03
+:a053c8c470f3
 "*String used by ido to separate the alternatives in the minibuffer.
 Obsolete.  Set 3rd element of `ido-decorations' instead."
 :type '(choice string (const nil))
 :group 'ido)
-(defcustom ido-decorations '( "{" "}" " | " " | ..." "[" "]" " [No match]" " [Matched]")
+(defcustom ido-decorations '( "{" "}" " | " " | ..." "[" "]" " [No match]" " [Matched]" " [Not readable]")
 "*List of strings used by ido to display the alternatives in the minibuffer.
-There are 8 elements in this list, each is a pair of strings:
+There are 9 elements in this list:
 1st and 2nd elements are used as brackets around the prospect list,
 3rd element is the separator between prospects (ignored if ido-separator is set),
 4th element is the string inserted at the end of a truncated list of prospects,
 5th and 6th elements are used as brackets around the common match string which
 can be completed using TAB,
 7th element is the string displayed when there are a no matches, and
-8th element displayed if there is a single match (and faces are not used)."
+8th element is displayed if there is a single match (and faces are not used).
+9th element is displayed when the current directory is non-readable."
 :type '(repeat string)
 :group 'ido)
 (defcustom ido-use-faces t
 "*Non-nil means use ido faces to highlighting first match, only match and
 (defvar ido-cur-list)
 ;; Stores the list of items which are ignored when building
 ;; `ido-cur-list'.  It is in no specific order.
 (defvar ido-ignored-list)
+;; Remember if current directory is non-readable (so we cannot do completion).
+(defvar ido-directory-nonreadable)
 ;; Keep current item list if non-nil.
 (defvar ido-keep-item-list)
 ;; Process ido-ignore-* lists.
 nil
 (ido-trace "cd" dir)
 (setq ido-current-directory dir)
 (if (get-buffer ido-completion-buffer)
 	(kill-buffer ido-completion-buffer))
+(setq ido-directory-nonreadable (not (file-readable-p dir)))
 t))
 (defun ido-set-current-home (&optional dir)
 ;; Set ido's current directory to user's home directory
 (ido-set-current-directory (expand-file-name (or dir "~/"))))
 Return the name of a buffer selected.
 PROMPT is the prompt to give to the user.  DEFAULT if given is the default
 buffer to be selected, which will go to the front of the list.
 If REQUIRE-MATCH is non-nil, an existing-buffer must be selected.
 If INITIAL is non-nil, it specifies the initial input string."
-(let ((ido-current-directory nil))
+(let ((ido-current-directory nil)
+	(ido-directory-nonreadable nil))
 (ido-read-internal 'buffer prompt 'ido-buffer-history default require-match initial)))
 (defun ido-record-work-directory (&optional dir)
 (when (and (numberp ido-max-work-directory-list) (> ido-max-work-directory-list 0))
 (if (and (setq dir (or dir ido-current-directory)) (> (length dir) 0))
 (and ido-work-file-list (equal (car ido-work-file-list) name))
 (setq ido-work-file-list (cons name (delete name ido-work-file-list))))
 (if (> (length ido-work-file-list) ido-max-work-file-list)
 	(setcdr (nthcdr (1- ido-max-work-file-list) ido-work-file-list) nil))))
+(defun ido-expand-directory (dir)
+;; Expand DIR or use DEFAULT-DIRECTORY if nil.
+;; Add final slash to result in case it was missing from DEFAULT-DIRECTORY.
+(ido-final-slash (expand-file-name (or dir default-directory)) t))
 (defun ido-file-internal (method &optional fallback default prompt item initial)
 ;; Internal function for ido-find-file and friends
 (unless item
 (setq item 'file))
-(let ((ido-current-directory (expand-file-name (or default default-directory)))
+(let* ((ido-current-directory (ido-expand-directory default))
-	filename)
+	 (ido-directory-nonreadable (not (file-readable-p ido-current-directory)))
+	 filename)
 (cond
 ((or (not ido-mode) (ido-is-slow-ftp-host))
 (setq filename t
 	    ido-exit 'fallback))
 (if ido-temp-list
 (nconc ido-temp-list items)
 (setq ido-temp-list items)))
 (defun ido-file-name-all-completions1 (dir)
-(if (and ido-enable-tramp-completion
+(cond
-	   (string-match "\\`/\\([^/:]+:\\([^/:@]+@\\)?\\)\\'" dir))
+((not (file-readable-p dir)) '())
+((and ido-enable-tramp-completion
-;; Trick tramp's file-name-all-completions handler to DTRT, as it
+	 (string-match "\\`/\\([^/:]+:\\([^/:@]+@\\)?\\)\\'" dir))
-;; has some pretty obscure requirements.  This seems to work...
-;; /ftp:		=> (f-n-a-c "/ftp:" "")
+;; Trick tramp's file-name-all-completions handler to DTRT, as it
-;; /ftp:kfs:	=> (f-n-a-c "" "/ftp:kfs:")
+;; has some pretty obscure requirements.  This seems to work...
-;; /ftp:kfs@      => (f-n-a-c "ftp:kfs@" "/")
+;; /ftp:		=> (f-n-a-c "/ftp:" "")
-;; /ftp:kfs@kfs:  => (f-n-a-c "" "/ftp:kfs@kfs:")
+;; /ftp:kfs:	=> (f-n-a-c "" "/ftp:kfs:")
-;; Currently no attempt is made to handle multi: stuff.
+;; /ftp:kfs@      => (f-n-a-c "ftp:kfs@" "/")
+;; /ftp:kfs@kfs:  => (f-n-a-c "" "/ftp:kfs@kfs:")
-(let* ((prefix (match-string 1 dir))
+;; Currently no attempt is made to handle multi: stuff.
-	     (user-flag (match-beginning 2))
-	     (len (and prefix (length prefix)))
+(let* ((prefix (match-string 1 dir))
-	     compl)
+	   (user-flag (match-beginning 2))
-	(if user-flag
+	   (len (and prefix (length prefix)))
-	    (setq dir (substring dir 1)))
+	   compl)
-	(require 'tramp nil t)
+(if user-flag
-	(ido-trace "tramp complete" dir)
+	  (setq dir (substring dir 1)))
-	(setq compl (file-name-all-completions dir (if user-flag "/" "")))
+(require 'tramp nil t)
-	(if (> len 0)
+(ido-trace "tramp complete" dir)
-	    (mapcar (lambda (c) (substring c len)) compl)
+(setq compl (file-name-all-completions dir (if user-flag "/" "")))
-	  compl))
+(if (> len 0)
-(file-name-all-completions "" dir)))
+	  (mapcar (lambda (c) (substring c len)) compl)
+	compl)))
+(t
+(file-name-all-completions "" dir))))
 (defun ido-file-name-all-completions (dir)
 ;; Return name of all files in DIR
 ;; Uses and updates ido-dir-file-cache
 (if (and (numberp ido-max-dir-file-cache) (> ido-max-dir-file-cache 0)
 	    (ido-set-current-directory
 	     (if (memq system-type '(windows-nt ms-dos))
 		 (expand-file-name "/" ido-current-directory)
 	       "/"))
 	    (setq refresh t))
+	   ((and ido-directory-nonreadable
+		 (file-directory-p (concat ido-current-directory (file-name-directory contents))))
+	    (ido-set-current-directory
+	     (concat ido-current-directory (file-name-directory contents)))
+	    (setq refresh t))
 	   (t
 	    (ido-trace "try single dir")
 	    (setq try-single-dir-match t))))
 	 ((and (string-equal (substring contents -2 -1) "/")
 	   (concat ido-current-directory (car ido-matches)))
 	  (setq ido-exit 'refresh)
 	  (exit-minibuffer))
 	(when (and (not ido-matches)
+		   (not ido-directory-nonreadable)
 		   ;; ido-rescan ?
 		   ido-process-ignore-lists
 		   ido-ignored-list)
 	  (let ((ido-process-ignore-lists nil)
 		(ido-rotate ido-rotate)
 	       ido-rescan
 	       (not ido-matches)
 	       (memq ido-cur-item '(file dir))
 	       (not (ido-is-root-directory))
 	       (> (length contents) 1)
-	       (not (string-match "[$]" contents)))
+	       (not (string-match "[$]" contents))
+	       (not ido-directory-nonreadable))
 	  (ido-trace "merge?")
 	  (if ido-use-merged-list
 	      (ido-undo-merge-work-directory contents nil)
 	    (when (and (eq ido-try-merged-list t)
 		       (numberp ido-auto-merge-work-directories-length)
 			     first)
 	  (if ind (setq first (concat first ind)))
 	  (setq comps (cons first (cdr comps)))))
 (cond ((null comps)
-	   (if ido-report-no-match
+	   (cond
-	       (nth 6 ido-decorations)  ;; [No Match]
+	    (ido-directory-nonreadable
-	     ""))
+	     (or (nth 8 ido-decorations) " [Not readable]"))
+	    (ido-report-no-match
+	     (nth 6 ido-decorations))  ;; [No match]
+	    (t "")))
 	  ((null (cdr comps))		;one match
 	   (concat (if (> (length (ido-name (car comps))) (length name))
 		       ;; when there is one match, show the matching file name in full
 		       (concat (nth 4 ido-decorations)  ;; [ ... ]
 ((or (eq predicate 'file-directory-p)
 (memq this-command ido-read-file-name-as-directory-commands))
 (ido-read-directory-name prompt dir default-filename mustmatch initial))
 ((and (not (memq this-command ido-read-file-name-non-ido))
 	(or (null predicate) (eq predicate 'file-exists-p)))
-(let (filename
+(let* (filename
-	 ido-saved-vc-hb
+	  ido-saved-vc-hb
-	 (vc-handled-backends (and (boundp 'vc-handled-backends) vc-handled-backends))
+	  (vc-handled-backends (and (boundp 'vc-handled-backends) vc-handled-backends))
-	 (ido-current-directory (expand-file-name (or dir default-directory)))
+	  (ido-current-directory (ido-expand-directory dir))
-	 (ido-work-directory-index -1)
+	  (ido-directory-nonreadable (not (file-readable-p ido-current-directory)))
-	 (ido-work-file-index -1)
+	  (ido-work-directory-index -1)
-	 (ido-find-literal nil))
+	  (ido-work-file-index -1)
+	  (ido-find-literal nil))
 (setq filename
 	   (ido-read-internal 'file prompt 'ido-file-history default-filename mustmatch initial))
 (if filename
 	 (concat ido-current-directory filename))))
 (t
 ;;;###autoload
 (defun ido-read-directory-name (prompt &optional dir default-dirname mustmatch initial)
 "Read directory name, prompting with PROMPT and completing in directory DIR.
 See `read-file-name' for additional parameters."
-(let (filename
+(let* (filename
-	ido-saved-vc-hb
+	 ido-saved-vc-hb
-	(ido-current-directory (expand-file-name (or dir default-directory)))
+	 (ido-current-directory (ido-expand-directory dir))
-	(ido-work-directory-index -1)
+	 (ido-directory-nonreadable (not (file-readable-p ido-current-directory)))
-	(ido-work-file-index -1))
+	 (ido-work-directory-index -1)
+	 (ido-work-file-index -1))
 (setq filename
 	  (ido-read-internal 'dir prompt 'ido-file-history default-dirname mustmatch initial))
 (if filename
 	(if (and (stringp filename) (string-equal filename "."))
 	    ido-current-directory

Mercurial > emacs

comparison lisp/ido.el @ 53323:a053c8c470f3