comparison lisp/ChangeLog @ 112387:ac3e3168aca2

allout.el: Summary - migrate to defining allout mode using define-minor-mode instead of defun. Significantly clean-up internal keymap provisions, refactoring a bit and removing a lot of accumulated cruft. allout-mode-map is now a keymap by virtue of being an defalias to allout-mode-map-value, which contains the actual keymap structure. (allout-mode): Use define-minor-mode rather than defun. Remove now-unnecessary minor-mode setup activities from the body. Specify :keymap as allout-mode-map so the minor-mode-map-alist entry will be '(allout-mode . allout-mode-map) - see allout-mode-map-value, below. Adjust docstring to track changes. (allout-minor-mode): Remove this defalias, now that we're using define-minor-mode. (allout-mode-map): Set value to be 'allout-mode-map. The actual keymap is allout-mode-map-value, via defalias. (allout-mode-map-value): The variable holding the actual mode keymap structure, by virtue of defalias from allout-mode-map. (allout-compose-and-institute-keymap): Renamed from allout-bind-keys, and including the binding-composition functionality of the former produce-allout-mode-map and allout-setup-mode-map. (allout-institute-keymap): Take over the "setup" part of the former allout-setup-mode-map. Reassign allout-mode-map-value value and update the defalias. (allout-command-prefix) (allout-prefixed-keybindings) (allout-unprefixed-keybindings): Use allout-compose-and-institute-keymap to process the bindings. (allout-unprefixed-keybindings): Remove extraneous '?' question marks. (allout-prefixed-keybindings): Elide binding to (prefixed) \C-h - user can customize if they want to use that binding. Bind allout-copy-topic-as-kill to (prefixed) \M-k. Bind allout-up-current-level to (prefixed) \C-u. (I think i mistakenly elided that, previously, instead of the one for \C-h.) (allout-hotspot-key-handler): Remove attempt to resolve the key through the literal key-string lookup on allout-keybindings-list. That probably hasn't worked for a Long Time, and removal of allout-keybindings-list further simplifies the keybindings situation. (allout-pre-command-business): Use allout-mode-map-value instead of allout-mode-map. (allout-preempt-trailing-ctrl-h): Remove. The user can customize the bindings if they want to use a keybinding having a trailing \C-h. No deprecation needed since this feature was never in a release. (allout-keybindings-list): Remove. It's not been useful for a while. (See allout-hotspot-key-handler changes, above.) (produce-allout-mode-map): Remove. Consolidate into allout-compose-and-institute-keymap. (allout-mode-map-adjustments): Remove. No longer necessary with removal of allout-preempt-trailing-ctrl-h. (allout-setup-mode-map): Remove. Consolidate into allout-compose-and-institute-keymap and allout-institute-keymap.
author Ken Manheimer <ken.manheimer@gmail.com>
date Thu, 20 Jan 2011 13:13:30 -0500
parents 4ce9a7be0488
children 75fb060ecbc3
comparison
equal deleted inserted replaced
112386:4ce9a7be0488 112387:ac3e3168aca2
1 2011-01-20 Ken Manheimer <ken.manheimer@gmail.com>
2
3 * allout.el: Summary - migrate to defining allout mode using
4 define-minor-mode instead of defun. Significantly clean-up
5 internal keymap provisions, refactoring and, in the process,
6 removing a lot of accumulated cruft.
7
8 allout-mode-map is now a keymap by virtue of being a defalias to
9 allout-mode-map-value, which contains the actual keymap structure.
10
11 (allout-mode): Use define-minor-mode rather than defun. Remove
12 now-unnecessary minor-mode setup activities from the body.
13 Specify :keymap as allout-mode-map so the minor-mode-map-alist
14 entry will be '(allout-mode . allout-mode-map) - see
15 allout-mode-map-value, below. Adjust docstring to track changes.
16 (allout-minor-mode): Remove this defalias, now that we're using
17 define-minor-mode.
18 (allout-mode-map): Set value to be 'allout-mode-map. The actual
19 keymap is allout-mode-map-value, via defalias.
20 (allout-mode-map-value): The variable holding the actual mode
21 keymap structure, by virtue of defalias from allout-mode-map.
22 (allout-compose-and-institute-keymap): Renamed from
23 allout-bind-keys, and including the binding-composition
24 functionality of the former produce-allout-mode-map and
25 allout-setup-mode-map.
26 (allout-institute-keymap): Take over the "setup" part of the former
27 allout-setup-mode-map. Reassign allout-mode-map-value value and
28 update the defalias.
29 (allout-command-prefix) (allout-prefixed-keybindings)
30 (allout-unprefixed-keybindings): Use
31 allout-compose-and-institute-keymap to process the bindings.
32 (allout-unprefixed-keybindings): Remove extraneous '?' question
33 marks.
34 (allout-prefixed-keybindings): Elide binding to (prefixed) \C-h -
35 user can customize if they want to use that binding. Bind
36 allout-copy-topic-as-kill to (prefixed) \M-k. Bind
37 allout-up-current-level to (prefixed) \C-u. (I think i mistakenly
38 elided that, previously, instead of the one for \C-h.)
39 (allout-hotspot-key-handler): Remove attempt to resolve the key
40 through the literal key-string lookup on allout-keybindings-list.
41 That probably hasn't worked for a Long Time, and removal of
42 allout-keybindings-list further simplifies the keybindings
43 situation.
44 (allout-pre-command-business): Use allout-mode-map-value instead
45 of allout-mode-map.
46 (allout-preempt-trailing-ctrl-h): Remove. The user can customize
47 the bindings if they want to use a keybinding having a trailing
48 \C-h. No deprecation needed since this feature was never in a
49 release.
50 (allout-keybindings-list): Remove. It's not been useful for a
51 while. (See allout-hotspot-key-handler changes, above.)
52 (produce-allout-mode-map): Remove. Consolidate into
53 allout-compose-and-institute-keymap.
54 (allout-mode-map-adjustments): Remove. No longer necessary with
55 removal of allout-preempt-trailing-ctrl-h.
56 (allout-setup-mode-map): Remove. Consolidate into
57 allout-compose-and-institute-keymap and allout-institute-keymap.
58
1 2011-01-20 Glenn Morris <rgm@gnu.org> 59 2011-01-20 Glenn Morris <rgm@gnu.org>
2 60
3 * vc/vc-svn.el (vc-svn-after-dir-status): Tweak previous change. 61 * vc/vc-svn.el (vc-svn-after-dir-status): Tweak previous change.
4 62
5 * simple.el (read-expression-history): Remove, it's in minibuf.c. 63 * simple.el (read-expression-history): Remove, it's in minibuf.c.