comparison lisp/emacs-lisp/checkdoc.el @ 43133:c929176c272b

(checkdoc-this-string-valid-engine): Replace foo-p as var name with foo-flag, not foo-p-flag.

43132:0dd2ebecd217

		  "Flag variable doc strings should usually start: Non-nil means"
		  s (marker-position e) t))
	     ;; If the doc string starts with "Non-nil means"
	     (if (and (looking-at "\"\\*?Non-nil\\s-+means\\s-+")
		      (not (string-match "-flag$" (car fp))))
		 (if (checkdoc-y-or-n-p
		      (format
		       "Rename to %s and Query-Replace all occurances? "
		       (concat (car fp) "-flag")))
		     (progn
		       (beginning-of-defun)
		       (query-replace-regexp
			(concat "\\<" (regexp-quote (car fp)) "\\>")
			(concat (car fp) "-flag")))
		   (checkdoc-create-error
		    "Flag variable names should normally end in `-flag'" s
		    (marker-position e))))
	     ;; Done with variables
	     ))
	   (t
	    ;; This if we are in a function definition
	    (or

43133:c929176c272b

		  "Flag variable doc strings should usually start: Non-nil means"
		  s (marker-position e) t))
	     ;; If the doc string starts with "Non-nil means"
	     (if (and (looking-at "\"\\*?Non-nil\\s-+means\\s-+")
		      (not (string-match "-flag$" (car fp))))
		 (let ((newname
			(if (string-match "-p$" (car fp))
			    (concat (substring (car fp) 0 -2) "-flag")
			  (concat (car fp) "-flag"))))
		   (if (checkdoc-y-or-n-p
			(format
			 "Rename to %s and Query-Replace all occurances? "
			 newname))
		       (progn
			 (beginning-of-defun)
			 (query-replace-regexp
			  (concat "\\<" (regexp-quote (car fp)) "\\>")
			  newname))
		     (checkdoc-create-error
		      "Flag variable names should normally end in `-flag'" s
		      (marker-position e)))))
	     ;; Done with variables
	     ))
	   (t
	    ;; This if we are in a function definition
	    (or