diff lisp/cedet/semantic/analyze/debug.el @ 105799:3fe6da4a95a9

* cedet/srecode/srt-mode.el (semantic-analyze-possible-completions): * cedet/semantic/symref/list.el (semantic-symref-rb-toggle-expand-tag): * cedet/semantic/symref/grep.el (semantic-symref-perform-search): * cedet/semantic/bovine/gcc.el (semantic-gcc-query): * cedet/semantic/bovine/c.el (semantic-c-parse-lexical-token): * cedet/semantic/analyze/debug.el (semantic-analyzer-debug-add-buttons) (semantic-analyzer-debug-global-symbol) (semantic-analyzer-debug-missing-innertype) (semantic-analyzer-debug-insert-include-summary): * cedet/semantic/util.el (semantic-file-tag-table): (semantic-describe-buffer-var-helper, semantic-something-to-tag-table) (semantic-recursive-find-nonterminal-by-name): * cedet/semantic/tag-ls.el (semantic-tag-calculate-parent-default): * cedet/semantic/tag-file.el (semantic-prototype-file): * cedet/semantic/symref.el (semantic-symref-parse-tool-output): * cedet/semantic/sb.el (semantic-sb-fetch-tag-table): * cedet/semantic/lex-spp.el (semantic-lex-spp-lex-text-string): * cedet/semantic/idle.el (semantic-idle-work-for-one-buffer): (semantic-idle-summary-maybe-highlight): * cedet/semantic/ia-sb.el (semantic-ia-speedbar) (semantic-ia-sb-tag-info): * cedet/semantic/grammar.el (semantic-analyze-possible-completions): * cedet/semantic/find.el (semantic-brute-find-tag-by-position): * cedet/semantic/ede-grammar.el (project-compile-target): (ede-proj-makefile-insert-variables): * cedet/semantic/debug.el (semantic-debug-set-parser-location): (semantic-debug-set-source-location, semantic-debug-interface-layout) (semantic-debug-mode, semantic-debug): * cedet/semantic/db.el (semanticdb-needs-refresh-p): * cedet/semantic/db-typecache.el (semanticdb-typecache-refresh-for-buffer): * cedet/semantic/db-javascript.el (semanticdb-equivalent-mode): * cedet/semantic/db-find.el (semanticdb-find-log-new-search) (semanticdb-find-translate-path-includes--internal) (semanticdb-reset-log, semanticdb-find-log-activity): * cedet/semantic/db-file.el (object-write): * cedet/semantic/db-el.el (semanticdb-equivalent-mode): * cedet/semantic/db-ebrowse.el (semanticdb-ebrowse-C-file-p) (semanticdb-create-ebrowse-database): * cedet/semantic/db-debug.el (semanticdb-table-sanity-check): * cedet/semantic/complete.el (semantic-displayor-focus-request) (semantic-collector-calculate-completions-raw) (semantic-complete-read-tag-analyzer): * cedet/semantic/analyze.el (semantic-analyze-pulse): * cedet/ede/util.el (ede-update-version-in-source): * cedet/ede/proj.el (project-delete-target): * cedet/ede/proj-elisp.el (ede-update-version-in-source) (ede-proj-flush-autoconf): * cedet/ede/pconf.el (ede-proj-configure-synchronize) (ede-proj-configure-synchronize): * cedet/ede/locate.el (ede-locate-file-in-project-impl): * cedet/ede/linux.el (ede-linux-version): * cedet/ede/emacs.el (ede-emacs-version): * cedet/ede/dired.el (ede-dired-add-to-target): * cedet/ede.el (ede-buffer-header-file, ede-find-target) (ede-buffer-documentation-files, ede-project-buffers, ede-set) (ede-target-buffers, ede-buffers, ede-make-project-local-variable): * cedet/cedet-idutils.el (cedet-idutils-fnid-call): (cedet-idutils-lid-call, cedet-idutils-expand-filename) (cedet-idutils-version-check): * cedet/cedet-global.el (cedet-gnu-global-call): (cedet-gnu-global-expand-filename, cedet-gnu-global-root) (cedet-gnu-global-version-check, cedet-gnu-global-scan-hits): * cedet/cedet-cscope.el (cedet-cscope-call) (cedet-cscope-expand-filename, cedet-cscope-version-check): Use with-current-buffer. * cedet/ede.el (ede-make-project-local-variable) (ede-set-project-variables, ede-set): Use dolist.

--- a/lisp/cedet/semantic/analyze/debug.el	Fri Oct 30 02:00:11 2009 +0000
+++ b/lisp/cedet/semantic/analyze/debug.el	Fri Oct 30 02:16:41 2009 +0000
@@ -104,8 +104,7 @@
 	;; NOTE: This line is copied from semantic-analyze-current-context.
 	;;       You will need to update both places.
 	(condition-case err
-	    (save-excursion
-	      (set-buffer origbuf)
+	    (with-current-buffer origbuf
 	      (let* ((position (or (cdr-safe (oref ctxt bounds)) (point)))
 		     (prefixtypes nil) ; Used as type return
 		     (scope (semantic-calculate-scope position))
@@ -246,13 +245,11 @@
 	  (princ "\nSemantic has found the datatype ")
 	  (semantic-analyzer-debug-insert-tag dt)
 	  (if (or (not (semantic-equivalent-tag-p ots dt))
-		  (not (save-excursion
-			 (set-buffer orig-buffer)
+		  (not (with-current-buffer orig-buffer
 			 (car (semantic-analyze-dereference-metatype
 			  ots (oref ctxt scope))))))
 	      (let ((lasttype ots)
-		    (nexttype (save-excursion
-				(set-buffer orig-buffer)
+		    (nexttype (with-current-buffer orig-buffer
 				(car (semantic-analyze-dereference-metatype
 				 ots (oref ctxt scope))))))
 		(if (eq nexttype lasttype)
@@ -274,8 +271,7 @@
 		  (princ "\n")
 		  (setq lasttype nexttype
 			nexttype
-			(save-excursion
-			  (set-buffer orig-buffer)
+			(with-current-buffer orig-buffer
 			  (car (semantic-analyze-dereference-metatype
 			   nexttype (oref ctxt scope)))))
 		  )
@@ -391,21 +387,17 @@
   (let ((inc (semantic-find-tags-by-class 'include table))
 	;;(path (semanticdb-find-test-translate-path-no-loading))
 	(unk
-	 (save-excursion
-	   (set-buffer (semanticdb-get-buffer table))
+	 (with-current-buffer (semanticdb-get-buffer table)
 	   semanticdb-find-lost-includes))
 	(ip
-	 (save-excursion
-	   (set-buffer (semanticdb-get-buffer table))
+	 (with-current-buffer (semanticdb-get-buffer table)
 	   semantic-dependency-system-include-path))
 	(edeobj
-	 (save-excursion
-	   (set-buffer (semanticdb-get-buffer table))
+	 (with-current-buffer (semanticdb-get-buffer table)
 	   (and (boundp 'ede-object)
 		ede-object)))
 	(edeproj
-	 (save-excursion
-	   (set-buffer (semanticdb-get-buffer table))
+	 (with-current-buffer (semanticdb-get-buffer table)
 	   (and (boundp 'ede-object-project)
 		ede-object-project))))
 
@@ -589,9 +581,8 @@
 Look for key expressions, and add push-buttons near them."
   (let ((orig-buffer (make-marker)))
     (set-marker orig-buffer (point) (current-buffer))
-    (save-excursion
-      ;; Get a buffer ready.
-      (set-buffer "*Help*")
+    ;; Get a buffer ready.
+    (with-current-buffer "*Help*"
       (toggle-read-only -1)
       (goto-char (point-min))
       (set (make-local-variable 'semantic-analyzer-debug-orig) orig-buffer)