view admin/notes/newfile @ 106768:21fd634f447a

Make line<->pixel_y conversion macros aware of native menu/tool bars. They are placed above the internal border. This supersedes special treatment of native tool bars in the display code. This fixes wrong display position of native menu bars and bogus mouse highlighting of native tool bars, both of which can be found when internal border width is large. Also it fixes wrong flashed part on visible bell with native menu bars. * frame.h (FRAME_TOP_MARGIN_HEIGHT): New macro. (FRAME_LINE_TO_PIXEL_Y, FRAME_PIXEL_Y_TO_LINE): Take account of pseudo windows above internal border. * window.h (WINDOW_MENU_BAR_P, WINDOW_TOOL_BAR_P): New macros. (WINDOW_TOP_EDGE_Y, WINDOW_BOTTOM_EDGE_Y): Take account of pseudo windows above internal border. * xdisp.c (get_glyph_string_clip_rects, init_glyph_string): Don't treat tool bar windows specially. * xfns.c (x_set_tool_bar_lines): Take account of menu bar height. * xterm.c (x_after_update_window_line): Don't treat tool bar windows specially. (XTflash): Take account of menu bar height. * w32term.c (x_after_update_window_line): Don't treat tool bar windows specially.

CHECKLIST FOR ADDING A NEW FILE TO EMACS -*- outline -*-

** Make sure the author(s) have a copyright assignment/disclaimer.

** Make sure the file matches the standard Emacs template (header
format, copyright and license notice, etc).

** Make sure the filename does not cause the DOS port any problems (8+3).
Run the `doschk' program like this:

    find /path/to/emacs -print | doschk

and examine the output for DOS-related problems.  The sections of
output under the headings "The following files are not valid DOS file
names:" and "The following resolve to the same DOS file names:" should
not include any files that end up in the release tarball.

** Make the ChangeLog entry in the name of the author(s), not your own name.

** If appropriate, add an entry to lisp/Makefile.in ELCFILES.

** If appropriate, check that the file compiles OK and that Emacs
builds fine with it.  Address any compilation warnings.

** If a major contribution, consider adding an entry to the
Acknowledgments in doc/emacs/emacs.texi and ack.texi.

** If appropriate, add a short NEWS entry.

** If appropriate, update make-dist (not needed with "standard" file
names, eg *.el).