# HG changeset patch # User Dan Nicolaescu # Date 1228921040 0 # Node ID 00d91c609c411f29e1b5539f6d8dc3e9118d70b4 # Parent 7dde9e3fb6ae17dfd2e21a3a3e48c2980821f1e1 (EMACS_DAEMON): Remove definition. (decode_options): Do not allow an empty alternate_editor on WINDOWSNT. (print_help_and_exit): Replace EMACS_DAEMON with WINDOWSNT. (start_daemon_and_retry_set_socket): Likewise. diff -r 7dde9e3fb6ae -r 00d91c609c41 lib-src/ChangeLog --- a/lib-src/ChangeLog Wed Dec 10 10:44:34 2008 +0000 +++ b/lib-src/ChangeLog Wed Dec 10 14:57:20 2008 +0000 @@ -1,3 +1,11 @@ +2008-12-10 Dan Nicolaescu + + * emacsclient.c (EMACS_DAEMON): Remove definition. + (decode_options): Do not allow an empty alternate_editor on + WINDOWSNT. + (print_help_and_exit): Replace EMACS_DAEMON with WINDOWSNT. + (start_daemon_and_retry_set_socket): Likewise. + 2008-12-10 Juanma Barranquero * emacsclient.c [!WINDOWSNT] (EMACS_DAEMON): New define. diff -r 7dde9e3fb6ae -r 00d91c609c41 lib-src/emacsclient.c --- a/lib-src/emacsclient.c Wed Dec 10 10:44:34 2008 +0000 +++ b/lib-src/emacsclient.c Wed Dec 10 14:57:20 2008 +0000 @@ -54,8 +54,6 @@ # define CLOSE_SOCKET close # define INITIALIZE() -# define EMACS_DAEMON - #endif /* !WINDOWSNT */ #undef signal @@ -586,6 +584,15 @@ arguments or expressions given. */ if (nowait && tty && argc - optind > 0) current_frame = 1; + +#ifdef WINDOWSNT + if (alternate_editor && alternate_editor == '\0') + { + message (TRUE, "--alternate-editor argument or ALTERNATE_EDITOR variable cannot be\n\ +an empty string"); + exit (EXIT_FAILURE); + } +#endif /* WINDOWSNT */ } @@ -618,10 +625,10 @@ Set filename of the TCP authentication file\n\ -a, --alternate-editor=EDITOR\n\ Editor to fallback to if the server is not running\n" -#ifdef EMACS_DAEMON +#ifdef WINDOWSNT " If EDITOR is the empty string, start Emacs in daemon\n\ mode and try connecting again\n" -#endif +#endif /* WINDOWSNT */ "\n\ Report bugs to bug-gnu-emacs@gnu.org.\n", progname); exit (EXIT_SUCCESS); @@ -1419,7 +1426,7 @@ void start_daemon_and_retry_set_socket (void) { -#ifdef EMACS_DAEMON +#ifndef WINDOWSNT pid_t dpid; int status; pid_t p; @@ -1457,7 +1464,7 @@ execvp ("emacs", d_argv); message (TRUE, "%s: error starting emacs daemon\n", progname); } -#endif /* EMACS_DAEMON */ +#endif /* WINDOWSNT */ } int @@ -1468,7 +1475,7 @@ int i, rl, needlf = 0; char *cwd, *str; char string[BUFSIZ+1]; - int null_socket_name, null_server_file, start_daemon_if_needed = 0; + int null_socket_name, null_server_file, start_daemon_if_needed; main_argv = argv; progname = argv[0]; @@ -1484,12 +1491,10 @@ exit (EXIT_FAILURE); } -#ifdef EMACS_DAEMON /* If alternate_editor is the empty string, start the emacs daemon in case of failure to connect. */ start_daemon_if_needed = (alternate_editor && (alternate_editor[0] == '\0')); -#endif /* EMACS_DAEMON */ if (start_daemon_if_needed) { /* set_socket changes the values for socket_name and