# HG changeset patch # User Andreas Schwab # Date 1258891860 0 # Node ID 234022ddfcd198422ea56f72c2614782e8169bfc # Parent a2ee981efbec26e076ae1577ccd24b534a99a3b2 (simple_search): Avoid CHAR_TO_BYTE in inner loop when searching backwards through multibyte buffer. diff -r a2ee981efbec -r 234022ddfcd1 src/ChangeLog --- a/src/ChangeLog Sun Nov 22 03:14:14 2009 +0000 +++ b/src/ChangeLog Sun Nov 22 12:11:00 2009 +0000 @@ -1,3 +1,8 @@ +2009-11-22 Andreas Schwab + + * search.c (simple_search): Avoid CHAR_TO_BYTE in inner loop when + searching backwards through multibyte buffer. + 2009-11-21 Jan Djärv * xterm.c: #include xgselect.h. diff -r a2ee981efbec -r 234022ddfcd1 src/search.c --- a/src/search.c Sun Nov 22 03:14:14 2009 +0000 +++ b/src/search.c Sun Nov 22 12:11:00 2009 +0000 @@ -1609,39 +1609,36 @@ while (1) { /* Try matching at position POS. */ - EMACS_INT this_pos = pos - len; - EMACS_INT this_pos_byte; + EMACS_INT this_pos = pos; + EMACS_INT this_pos_byte = pos_byte; int this_len = len; - unsigned char *p = pat; - - if (this_pos < lim || (pos_byte - len_byte) < lim_byte) + unsigned char *p = pat + len_byte; + + if (this_pos - len < lim || (pos_byte - len_byte) < lim_byte) goto stop; - this_pos_byte = CHAR_TO_BYTE (this_pos); - match_byte = pos_byte - this_pos_byte; while (this_len > 0) { - int charlen, buf_charlen; + int charlen; int pat_ch, buf_ch; - pat_ch = STRING_CHAR_AND_LENGTH (p, charlen); - buf_ch = STRING_CHAR_AND_LENGTH (BYTE_POS_ADDR (this_pos_byte), - buf_charlen); + DEC_BOTH (this_pos, this_pos_byte); + PREV_CHAR_BOUNDARY (p, pat); + pat_ch = STRING_CHAR (p); + buf_ch = STRING_CHAR (BYTE_POS_ADDR (this_pos_byte)); TRANSLATE (buf_ch, trt, buf_ch); if (buf_ch != pat_ch) break; this_len--; - p += charlen; - this_pos_byte += buf_charlen; - this_pos++; } if (this_len == 0) { - pos -= len; - pos_byte -= match_byte; + match_byte = pos_byte - this_pos_byte; + pos = this_pos; + pos_byte = this_pos_byte; break; }