# HG changeset patch # User Luc Teirlinck # Date 1121480748 0 # Node ID 25d7b8b15748a40981b4b200e6391b511a95610e # Parent 1721aefddad61db384c3609b7bfd7b90c511d5f5 (define-minor-mode): Avoid constructing a defcustom with two :set or :type keywords. diff -r 1721aefddad6 -r 25d7b8b15748 lisp/emacs-lisp/easy-mmode.el --- a/lisp/emacs-lisp/easy-mmode.el Sat Jul 16 02:24:21 2005 +0000 +++ b/lisp/emacs-lisp/easy-mmode.el Sat Jul 16 02:25:48 2005 +0000 @@ -142,8 +142,10 @@ (let* ((mode-name (symbol-name mode)) (pretty-name (easy-mmode-pretty-mode-name mode lighter)) (globalp nil) + (set nil) (initialize nil) (group nil) + (type nil) (extra-args nil) (extra-keywords nil) (require t) @@ -160,8 +162,10 @@ (:lighter (setq lighter (pop body))) (:global (setq globalp (pop body))) (:extra-args (setq extra-args (pop body))) + (:set (setq set (list :set (pop body)))) (:initialize (setq initialize (list :initialize (pop body)))) (:group (setq group (nconc group (list :group (pop body))))) + (:type (setq type (list :type (pop body)))) (:require (setq require (pop body))) (:keymap (setq keymap (pop body))) (t (push keyw extra-keywords) (push (pop body) extra-keywords)))) @@ -169,9 +173,10 @@ (setq keymap-sym (if (and keymap (symbolp keymap)) keymap (intern (concat mode-name "-map")))) + (unless set (setq set '(:set 'custom-set-minor-mode))) + (unless initialize - (setq initialize - '(:initialize 'custom-initialize-default))) + (setq initialize '(:initialize 'custom-initialize-default))) (unless group ;; We might as well provide a best-guess default group. @@ -179,6 +184,8 @@ `(:group ',(intern (replace-regexp-in-string "-mode\\'" "" mode-name))))) + (unless type (setq type '(:type 'boolean))) + `(progn ;; Define the variable to enable or disable the mode. ,(if (not globalp) @@ -201,10 +208,10 @@ `(defcustom ,mode ,init-value ,(format base-doc-string pretty-name mode mode) - :set 'custom-set-minor-mode + ,@set ,@initialize ,@group - :type 'boolean + ,@type ,@(cond ((not (and curfile require)) nil) ((not (eq require t)) `(:require ,require)))