# HG changeset patch # User Jason Rumney # Date 1062025074 0 # Node ID 373b8dc17c8be2898450dc3d83002d6e690d8984 # Parent f88c9c046632255335e854083df17e63f1508b7b (sys_pipe): Protect against file descriptor overflow. diff -r f88c9c046632 -r 373b8dc17c8b src/w32.c --- a/src/w32.c Wed Aug 27 22:57:13 2003 +0000 +++ b/src/w32.c Wed Aug 27 22:57:54 2003 +0000 @@ -3450,11 +3450,22 @@ if (rc == 0) { - flags = FILE_PIPE | FILE_READ | FILE_BINARY; - fd_info[phandles[0]].flags = flags; - - flags = FILE_PIPE | FILE_WRITE | FILE_BINARY; - fd_info[phandles[1]].flags = flags; + /* Protect against overflow, since Windows can open more handles than + our fd_info array has room for. */ + if (phandles[0] >= MAXDESC || phandles[1] >= MAXDESC) + { + _close (phandles[0]); + _close (phandles[1]); + rc = -1; + } + else + { + flags = FILE_PIPE | FILE_READ | FILE_BINARY; + fd_info[phandles[0]].flags = flags; + + flags = FILE_PIPE | FILE_WRITE | FILE_BINARY; + fd_info[phandles[1]].flags = flags; + } } return rc;