# HG changeset patch # User Juri Linkov # Date 1101628561 0 # Node ID 4663989dd34a0cebadf1663811d34c54b74260fb # Parent dae5b7bb7dacfb08bde70a1fc0377fab6132a3ab (compare-windows-highlight): Attach each overlay to its window to properly highlight differences while comparing two windows of the same buffer. Fix arguments. (compare-windows-sync-default-function): Fix arguments of `compare-windows-highlight'. diff -r dae5b7bb7dac -r 4663989dd34a lisp/compare-w.el --- a/lisp/compare-w.el Sun Nov 28 02:31:53 2004 +0000 +++ b/lisp/compare-w.el Sun Nov 28 07:56:01 2004 +0000 @@ -283,7 +283,8 @@ ;; to be used when this function is called on second window. (defun compare-windows-sync-default-function () (if (not compare-windows-sync-point) - (let* ((w2 (next-window (selected-window))) + (let* ((w1 (selected-window)) + (w2 (next-window w1)) (b2 (window-buffer w2)) (point-max2 (with-current-buffer b2 (point-max))) (op2 (window-point w2)) @@ -326,7 +327,8 @@ ;; use closest matching points (i.e. points with minimal sum) (setq p12 (cdr (assq (apply 'min (mapcar 'car p12s)) p12s))) (goto-char (car p12)) - (compare-windows-highlight op1 (car p12) op2 (cadr p12) b2)) + (compare-windows-highlight op1 (car p12) (current-buffer) w1 + op2 (cadr p12) b2 w2)) (setq compare-windows-sync-point (or (cadr p12) t))) ;; else set point in the second window to the pre-calculated value (if (numberp compare-windows-sync-point) @@ -334,18 +336,20 @@ (setq compare-windows-sync-point nil))) ;; Highlight differences -(defun compare-windows-highlight (beg1 end1 beg2 end2 buf2) +(defun compare-windows-highlight (beg1 end1 b1 w1 beg2 end2 b2 w2) (when compare-windows-highlight (if compare-windows-overlay1 - (move-overlay compare-windows-overlay1 beg1 end1 (current-buffer)) - (setq compare-windows-overlay1 (make-overlay beg1 end1 (current-buffer))) + (move-overlay compare-windows-overlay1 beg1 end1 b1) + (setq compare-windows-overlay1 (make-overlay beg1 end1 b1)) (overlay-put compare-windows-overlay1 'face 'compare-windows-face) (overlay-put compare-windows-overlay1 'priority 1)) + (overlay-put compare-windows-overlay1 'window w1) (if compare-windows-overlay2 - (move-overlay compare-windows-overlay2 beg2 end2 buf2) - (setq compare-windows-overlay2 (make-overlay beg2 end2 buf2)) + (move-overlay compare-windows-overlay2 beg2 end2 b2) + (setq compare-windows-overlay2 (make-overlay beg2 end2 b2)) (overlay-put compare-windows-overlay2 'face 'compare-windows-face) (overlay-put compare-windows-overlay2 'priority 1)) + (overlay-put compare-windows-overlay2 'window w2) ;; Remove highlighting before next command is executed (add-hook 'pre-command-hook 'compare-windows-dehighlight)))