# HG changeset patch # User Juanma Barranquero # Date 1117446109 0 # Node ID 58c1e48ab7bc555982749eed2678519667602d77 # Parent 4b7fa3ee8e9e47083782759ca95467071a64574a (thumbs-thumbname): The resulting thubname includes a hash value to improve its uniqueness, and has a ".jpg" extension. Also, it is now a valid filename on all systems. (thumbs-make-thumb): Use `let', not `let*'. (thumbs-show-thumbs-list): Check for JPEG availability. diff -r 4b7fa3ee8e9e -r 58c1e48ab7bc lisp/thumbs.el --- a/lisp/thumbs.el Mon May 30 08:20:19 2005 +0000 +++ b/lisp/thumbs.el Mon May 30 09:41:49 2005 +0000 @@ -302,18 +302,21 @@ (defun thumbs-thumbname (img) "Return a thumbnail name for the image IMG." - (concat thumbs-thumbsdir "/" - (subst-char-in-string - ?\ ?\_ - (apply - 'concat - (split-string - (expand-file-name img) "/"))))) + (convert-standard-filename + (let ((filename (expand-file-name img))) + (format "%s/%08x-%s.jpg" + thumbs-thumbsdir + (sxhash filename) + (subst-char-in-string + ?\s ?\_ + (apply + 'concat + (split-string filename "/"))))))) (defun thumbs-make-thumb (img) "Create the thumbnail for IMG." - (let* ((fn (expand-file-name img)) - (tn (thumbs-thumbname img))) + (let ((fn (expand-file-name img)) + (tn (thumbs-thumbname img))) (if (or (not (file-exists-p tn)) ;; This is not the right fix, but I don't understand ;; the external program or why it produces a geometry @@ -378,8 +381,9 @@ (unless (bobp) (newline)))) (defun thumbs-show-thumbs-list (L &optional buffer-name same-window) - (when (not (display-images-p)) - (error "Images are not supported in this Emacs session")) + (unless (and (display-images-p) + (image-type-available-p 'jpeg)) + (error "Required image type is not supported in this Emacs session")) (funcall (if same-window 'switch-to-buffer 'pop-to-buffer) (or buffer-name "*THUMB-View*")) (let ((inhibit-read-only t))