# HG changeset patch # User Juanma Barranquero # Date 1231900192 0 # Node ID 64a6da0f9aa200b7b01f88d498c7f7c9aa6f9c36 # Parent 886c8ef66ffc3da19d58c4478e514a4f94217715 * minibuffer.el (minibuffer-message): Fix regexp so it doesn't exclude MESSAGEs with internal square brackets (i.e., " this [test] message"). Use `string-match-p'. (completion--make-envvar-table, completion--file-name-table) (completion-pcm--string->pattern, completion-pcm--all-completions) (completion-pcm--filename-try-filter): Use `string-match-p'. diff -r 886c8ef66ffc -r 64a6da0f9aa2 lisp/ChangeLog --- a/lisp/ChangeLog Wed Jan 14 00:39:15 2009 +0000 +++ b/lisp/ChangeLog Wed Jan 14 02:29:52 2009 +0000 @@ -1,3 +1,12 @@ +2009-01-14 Juanma Barranquero + + * minibuffer.el (minibuffer-message): Fix regexp so it doesn't exclude + MESSAGEs with internal square brackets (i.e., " this [test] message"). + Use `string-match-p'. + (completion--make-envvar-table, completion--file-name-table) + (completion-pcm--string->pattern, completion-pcm--all-completions) + (completion-pcm--filename-try-filter): Use `string-match-p'. + 2009-01-14 Juri Linkov * progmodes/bug-reference.el (bug-reference-fontify): Check for @@ -16,7 +25,7 @@ 2009-01-13 Jason Rumney - * faces.el (face-valid-attribute-values): No stipple on w32. (Bug#884) + * faces.el (face-valid-attribute-values): No stipple on w32. (Bug#884) 2009-01-12 Juanma Barranquero diff -r 886c8ef66ffc -r 64a6da0f9aa2 lisp/minibuffer.el --- a/lisp/minibuffer.el Wed Jan 14 00:39:15 2009 +0000 +++ b/lisp/minibuffer.el Wed Jan 14 02:29:52 2009 +0000 @@ -250,7 +250,7 @@ If ARGS are provided, then pass MESSAGE through `format'." ;; Clear out any old echo-area message to make way for our new thing. (message nil) - (setq message (if (and (null args) (string-match "\\[.+\\]" message)) + (setq message (if (and (null args) (string-match-p "\\` *\\[.+\\]\\'" message)) ;; Make sure we can put-text-property. (copy-sequence message) (concat " [" message "]"))) @@ -949,7 +949,7 @@ (defun completion--make-envvar-table () (mapcar (lambda (enventry) - (substring enventry 0 (string-match "=" enventry))) + (substring enventry 0 (string-match-p "=" enventry))) process-environment)) (defconst completion--embedded-envvar-re @@ -985,7 +985,7 @@ ;; FIXME: Actually, this is not always right in the presence of ;; envvars, but there's not much we can do, I think. (let ((start (length (file-name-directory string))) - (end (string-match "/" (cdr action)))) + (end (string-match-p "/" (cdr action)))) (list* 'boundaries start end))) (t @@ -1359,7 +1359,7 @@ (p 0) (p0 0)) - (while (setq p (string-match completion-pcm--delim-wild-regex string p)) + (while (setq p (string-match-p completion-pcm--delim-wild-regex string p)) (push (substring string p0 p) pattern) (if (eq (aref string p) ?*) (progn @@ -1415,7 +1415,7 @@ compl (let ((poss ())) (dolist (c compl) - (when (string-match regex c) (push c poss))) + (when (string-match-p regex c) (push c poss))) poss))))) (defun completion-pcm--hilit-commonality (pattern completions) @@ -1614,9 +1614,9 @@ (regexp-opt completion-ignored-extensions) "\\)\\'"))) (dolist (f all) - (unless (string-match re f) (push f try))) + (unless (string-match-p re f) (push f try))) (or try all)))) - + (defun completion-pcm--merge-try (pattern all prefix suffix) (cond