# HG changeset patch # User Karl Berry # Date 1117299441 0 # Node ID 93362151dd3a932881ffdf7ec063561c39324e46 # Parent 28ffa958559dd280856839d63cf493b3dd78ab11 remove extraneous calls to shell-quote-argument diff -r 28ffa958559d -r 93362151dd3a lisp/ChangeLog --- a/lisp/ChangeLog Sat May 28 12:15:33 2005 +0000 +++ b/lisp/ChangeLog Sat May 28 16:57:21 2005 +0000 @@ -1,3 +1,11 @@ +2005-05-28 Karl Berry + + * textmodes/tex-mode.el: now that tex-send-command calls + shell-quote-argument (2005-03-31 change), remove all calls to + shell-quote-argument; they all end up invoking tex-send-command. + The double quoting loses on filenames with non-safe characters, + such as "@". Reported by Frederik Fouvry. + 2005-05-29 Nick Roberts * progmodes/gdb-ui.el (gdb-assembler-custom): Be more careful @@ -3106,11 +3114,6 @@ (fill-newline): Use fill-text-properties-at instead of text-properties-at. -2005-03-31 Karl Berry - - * textmodes/tex-mode.el (tex-compile): Use shell-quote-argument, - not comint-quote-filename. - 2005-03-31 Olive Lin (tiny change) * textmodes/tex-mode.el (tex-start-tex) Use shell-quote-argument, diff -r 28ffa958559d -r 93362151dd3a lisp/textmodes/tex-mode.el --- a/lisp/textmodes/tex-mode.el Sat May 28 12:15:33 2005 +0000 +++ b/lisp/textmodes/tex-mode.el Sat May 28 16:57:21 2005 +0000 @@ -1633,11 +1633,11 @@ (defvar tex-compile-commands '(((concat "pdf" tex-command " " (if (< 0 (length tex-start-commands)) - (shell-quote-argument tex-start-commands)) " %f") + tex-start-commands) " %f") t "%r.pdf") ((concat tex-command " " (if (< 0 (length tex-start-commands)) - (shell-quote-argument tex-start-commands)) " %f") + tex-start-commands) " %f") t "%r.dvi") ("yap %r &" "%r.dvi") ("xdvi %r &" "%r.dvi") @@ -1900,8 +1900,8 @@ (prog1 (file-name-directory (expand-file-name file)) (setq file (file-name-nondirectory file)))) (root (file-name-sans-extension file)) - (fspec (list (cons ?r (shell-quote-argument root)) - (cons ?f (shell-quote-argument file)))) + (fspec (list (cons ?r root) + (cons ?f file))) (default (tex-compile-default fspec))) (list default-directory (completing-read @@ -1922,14 +1922,13 @@ (compile-command (if star (concat (substring command 0 star) - (shell-quote-argument file) + file (substring command (1+ star))) (concat command " " tex-start-options (if (< 0 (length tex-start-commands)) - (concat - (shell-quote-argument tex-start-commands) " ")) - (shell-quote-argument file))))) + (concat tex-start-commands " ")) + file)))) (tex-send-tex-command compile-command dir))) (defun tex-send-tex-command (cmd &optional dir) @@ -2232,8 +2231,7 @@ (tex-start-shell)) (tex-send-command (if alt tex-alt-dvi-print-command tex-dvi-print-command) - (shell-quote-argument - print-file-name-dvi) + print-file-name-dvi t)))) (defun tex-alt-print ()