# HG changeset patch # User Stefan Monnier # Date 1289249622 18000 # Node ID 93e249d6d27c1272834c375b342beff146dec231 # Parent 85a2b871f225b933f646985565698759f27d528b * lisp/minibuffer.el (minibuffer-completion-help): Specify the end of the completion field. diff -r 85a2b871f225 -r 93e249d6d27c lisp/ChangeLog --- a/lisp/ChangeLog Mon Nov 08 13:56:10 2010 -0500 +++ b/lisp/ChangeLog Mon Nov 08 15:53:42 2010 -0500 @@ -1,5 +1,8 @@ 2010-11-08 Stefan Monnier + * minibuffer.el (minibuffer-completion-help): Specify the end of the + completion field (bug#7211). + * progmodes/python.el (python-font-lock-syntactic-keywords): (bug#7322) Fix handling of backslash escapes. (python-quote-syntax): Adjust accordingly. diff -r 85a2b871f225 -r 93e249d6d27c lisp/minibuffer.el --- a/lisp/minibuffer.el Mon Nov 08 13:56:10 2010 -0500 +++ b/lisp/minibuffer.el Mon Nov 08 15:53:42 2010 -0500 @@ -41,7 +41,7 @@ ;; provide the start info but not the end info in ;; completion-base-position. ;; - quoting is problematic. E.g. the double-dollar quoting used in -;; substitie-in-file-name (and hence read-file-name-internal) bumps +;; substitute-in-file-name (and hence read-file-name-internal) bumps ;; into various bugs: ;; - choose-completion doesn't know how to quote the text it inserts. ;; E.g. it fails to double the dollars in file-name completion, or @@ -1075,6 +1075,7 @@ (interactive) (message "Making completion list...") (lexical-let* ((start (field-beginning)) + (end (field-end)) (string (field-string)) (completions (completion-all-completions string @@ -1106,10 +1107,12 @@ completions))) (with-current-buffer standard-output (set (make-local-variable 'completion-base-position) - ;; FIXME: We should provide the END part as well, but - ;; currently completion-all-completions does not give - ;; us the necessary information. - (list (+ start base-size) nil))) + (list (+ start base-size) + ;; FIXME: We should pay attention to completion + ;; boundaries here, but currently + ;; completion-all-completions does not give us the + ;; necessary information. + end))) (display-completion-list completions))) ;; If there are no completions, or if the current input is already the