# HG changeset patch
# User Bill Wohler <wohler@newt.com>
# Date 1136969882 0
# Node ID b9b10fe7c97a621c3f21f207de9839c7eabda73a
# Parent  dfa5a760e24f9542da42b92bca102417a53bacc7
(mh-x-image-url-cache-canonicalize): Use url-hexify-string to remove
special characters from filenames (closes SF #1396499).

diff -r dfa5a760e24f -r b9b10fe7c97a lisp/mh-e/ChangeLog
--- a/lisp/mh-e/ChangeLog	Wed Jan 11 07:46:57 2006 +0000
+++ b/lisp/mh-e/ChangeLog	Wed Jan 11 08:58:02 2006 +0000
@@ -1,7 +1,14 @@
+2006-01-11  Bill Wohler  <wohler@newt.com>
+
+	* mh-utils.el (mh-x-image-url-cache-canonicalize): Use
+	url-hexify-string to remove special characters from filenames
+	(closes SF #1396499).
+
 2006-01-10  Bill Wohler  <wohler@newt.com>
 
 	* mh-comp.el (mh-insert-letter): If you choose a different folder,
-	the cur message is used (closes SF #1205890).
+	the cur message is used. Sync docstring with manual (closes SF
+	#1205890).
 
 	* mh-mime.el (mh-compose-forward): Use standard range argument
 	instead of messages. Use more powerful mh-read-range instead of
diff -r dfa5a760e24f -r b9b10fe7c97a lisp/mh-e/mh-utils.el
--- a/lisp/mh-e/mh-utils.el	Wed Jan 11 07:46:57 2006 +0000
+++ b/lisp/mh-e/mh-utils.el	Wed Jan 11 08:58:02 2006 +0000
@@ -1489,12 +1489,16 @@
 
 (defun mh-x-image-url-cache-canonicalize (url)
   "Canonicalize URL.
-Replace the ?/ character with a ?! character and append .png."
-   (format "%s/%s.png" mh-x-image-cache-directory
+Replace the ?/ character with a ?! character and append .png.
+Also replaces special characters with `url-hexify-string' since
+not all characters, such as :, are legal within Windows
+filenames. See URL `http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/fs/naming_a_file.asp'."
+  (format "%s/%s.png" mh-x-image-cache-directory
+          (url-hexify-string
            (with-temp-buffer
              (insert url)
              (mh-replace-string "/" "!")
-             (buffer-string))))
+             (buffer-string)))))
 
 (defun mh-x-image-set-download-state (file data)
   "Setup a symbolic link from FILE to DATA."