# HG changeset patch # User Bill Wohler # Date 1137204611 0 # Node ID bb73cb6860d2c2c05514fa5729a65575f0a31db6 # Parent dcf22699125268a0f0780844b347a212efefa9ec (require): Added Satyaki's comment regarding what needs to happen to remove this defadvice which caused a little discussion on emacs-devel today (see Subject: mh-e/mh-acros.el advices `require' incorrectly). diff -r dcf226991252 -r bb73cb6860d2 lisp/mh-e/ChangeLog --- a/lisp/mh-e/ChangeLog Sat Jan 14 02:05:23 2006 +0000 +++ b/lisp/mh-e/ChangeLog Sat Jan 14 02:10:11 2006 +0000 @@ -1,5 +1,10 @@ 2006-01-13 Bill Wohler + * mh-acros.el (require): Added Satyaki's comment regarding what + needs to happen to remove this defadvice which caused a little + discussion on emacs-devel today (see Subject: mh-e/mh-acros.el + advices `require' incorrectly). + * mh-search.el (mh-index-next-result-function): Add format to docstring. (mh-mairix-next-result): Use nil instead of () which doesn't stand diff -r dcf226991252 -r bb73cb6860d2 lisp/mh-e/mh-acros.el --- a/lisp/mh-e/mh-acros.el Sat Jan 14 02:05:23 2006 +0000 +++ b/lisp/mh-e/mh-acros.el Sat Jan 14 02:10:11 2006 +0000 @@ -150,6 +150,9 @@ (list 'nth ,x z))) (quote ,struct-name)))) +;; A better solution would be to use Stefan's change in bytecomp.el. +;; If it were checked in, we can drop the advice to require and it +;; will make things nicer elsewhere too. (defadvice require (around mh-prefer-el activate) "Modify `require' to load uncompiled MH-E files." (or (featurep (ad-get-arg 0))