# HG changeset patch # User Richard M. Stallman # Date 1050725917 0 # Node ID c3ba923eb0e9845ecb81f1b19576255c7549e38c # Parent 5a24a10b0246d3ebc74be0c44b5f5dc9fee4b2be (byte-compile-log-file, (byte-recompile-directory): Don't use byte-goto-log-buffer. Instead, set default-directory and then call compilation-mode. (byte-compile-from-buffer): Force byte-compile-last-position to end of buffer before issuing final warnings. diff -r 5a24a10b0246 -r c3ba923eb0e9 lisp/emacs-lisp/bytecomp.el --- a/lisp/emacs-lisp/bytecomp.el Sat Apr 19 04:16:15 2003 +0000 +++ b/lisp/emacs-lisp/bytecomp.el Sat Apr 19 04:18:37 2003 +0000 @@ -10,7 +10,7 @@ ;;; This version incorporates changes up to version 2.10 of the ;;; Zawinski-Furuseth compiler. -(defconst byte-compile-version "$Revision: 2.124 $") +(defconst byte-compile-version "$Revision: 2.125 $") ;; This file is part of GNU Emacs. @@ -949,7 +949,7 @@ (and (not (equal byte-compile-current-file byte-compile-last-logged-file)) (not noninteractive) (save-excursion - (byte-goto-log-buffer) + (set-buffer (get-buffer-create "*Compile-Log*")) (goto-char (point-max)) (let* ((dir (and byte-compile-current-file (file-name-directory byte-compile-current-file))) @@ -973,6 +973,9 @@ (unless was-same (insert (format "Entering directory `%s'\n" default-directory)))) (setq byte-compile-last-logged-file byte-compile-current-file) + ;; Do this after setting default-directory. + (unless (eq major-mode 'compilation-mode) + (compilation-mode)) pt)))) ;; Log a message STRING in *Compile-Log*. @@ -1424,8 +1427,11 @@ (save-some-buffers) (force-mode-line-update)) (save-current-buffer - (byte-goto-log-buffer) + (set-buffer (get-buffer-create "*Compile-Log*")) (setq default-directory (expand-file-name directory)) + ;; compilation-mode copies value of default-directory. + (unless (eq major-mode 'compilation-mode) + (compilation-mode)) (let ((directories (list (expand-file-name directory))) (default-directory default-directory) (skip-count 0) @@ -1727,6 +1733,9 @@ (byte-compile-file-form form))) ;; Compile pending forms at end of file. (byte-compile-flush-pending) + ;; Make warnings about unresolved functions + ;; give the end of the file as their position. + (setq byte-compile-last-position (point-max)) (byte-compile-warn-about-unresolved-functions) ;; Should we always do this? When calling multiple files, it ;; would be useful to delay this warning until all have