# HG changeset patch # User Francesco Potort # Date 1148381079 0 # Node ID d2542ee8a5c99b44eb6f7425d7992757061b5545 # Parent 74ce4d3e33b00afe625b03fe574e723e38fca62c (pop_open, socket_connection, KPOP_SERVICE): Added comments explaining why the "kpop" service is never used. diff -r 74ce4d3e33b0 -r d2542ee8a5c9 lib-src/pop.c --- a/lib-src/pop.c Tue May 23 10:43:33 2006 +0000 +++ b/lib-src/pop.c Tue May 23 10:44:39 2006 +0000 @@ -135,7 +135,7 @@ #define KPOP_PORT 1109 #define POP_SERVICE "pop3" /* we don't want the POP2 port! */ #ifdef KERBEROS -#define KPOP_SERVICE "kpop" +#define KPOP_SERVICE "kpop" /* never used: look for 20060515 to see why */ #endif char pop_error[ERROR_MAX]; @@ -264,10 +264,11 @@ return (0); } } - if (password) + if (password) /* always true, detected 20060515 */ flags |= POP_NO_KERBEROS; else - password = username; + password = username; /* dead code, detected 20060515 */ + /** "kpop" service is never used: look for 20060515 to see why **/ sock = socket_connection (host, flags); if (sock == -1) @@ -1047,6 +1048,7 @@ bzero ((char *) &addr, sizeof (addr)); addr.sin_family = AF_INET; + /** "kpop" service is never used: look for 20060515 to see why **/ #ifdef KERBEROS service = (flags & POP_NO_KERBEROS) ? POP_SERVICE : KPOP_SERVICE; #else @@ -1073,6 +1075,7 @@ } else { + /** "kpop" service is never used: look for 20060515 to see why **/ #ifdef KERBEROS addr.sin_port = htons ((flags & POP_NO_KERBEROS) ? POP_PORT : KPOP_PORT);