# HG changeset patch # User Eli Zaretskii # Date 1270125448 -10800 # Node ID dc45468b314057f671a73cabaf02593157a8fb6a # Parent 64415eac89e12da960b3ce273a896aa58459ec63 Fix bug #5816. xdisp.c (set_cursor_from_row): Fix cursor positioning when the string with `cursor' property comes from an `after-string' overlay. diff -r 64415eac89e1 -r dc45468b3140 src/ChangeLog --- a/src/ChangeLog Thu Apr 01 10:55:55 2010 +0000 +++ b/src/ChangeLog Thu Apr 01 15:37:28 2010 +0300 @@ -1,3 +1,9 @@ +2010-04-01 Eli Zaretskii + + * xdisp.c (set_cursor_from_row): Fix cursor positioning when the + string with `cursor' property comes from an `after-string' + overlay. (Bug#5816) + 2010-04-01 Glenn Morris * Makefile.in (LIBTIFF, LIBJPEG, LIBPNG, LIBGIF, LIBXPM, XFT_LIBS): diff -r 64415eac89e1 -r dc45468b3140 src/xdisp.c --- a/src/xdisp.c Thu Apr 01 10:55:55 2010 +0000 +++ b/src/xdisp.c Thu Apr 01 15:37:28 2010 +0300 @@ -12823,12 +12823,19 @@ str = glyph->object; tem = string_buffer_position_lim (w, str, pos, pos_after, 0); - if (pos <= tem) + if (tem == 0 /* from overlay */ + || pos <= tem) { /* If the string from which this glyph came is found in the buffer at point, then we've - found the glyph we've been looking for. */ - if (tem == pt_old) + found the glyph we've been looking for. If + it comes from an overlay (tem == 0), and it + has the `cursor' property on one of its + glyphs, record that glyph as a candidate for + displaying the cursor. (As in the + unidirectional version, we will display the + cursor on the last candidate we find.) */ + if (tem == 0 || tem == pt_old) { /* The glyphs from this string could have been reordered. Find the one with the @@ -12861,9 +12868,11 @@ } } - goto compute_x; + if (tem == pt_old) + goto compute_x; } - pos = tem + 1; /* don't find previous instances */ + if (tem) + pos = tem + 1; /* don't find previous instances */ } /* This string is not what we want; skip all of the glyphs that came from it. */