# HG changeset patch # User Karl Fogel # Date 1255067697 0 # Node ID e5035c6df58d855a345ed36b6df124a272ce0137 # Parent 0d8007720f3597bdf8c1ca96adab7e3aee69b802 * lisp/bookmark.el (bookmark-jump): Add new `display-func' parameter. (bookmark-jump-other-window): Just invoke bookmark-jump with new argument now, so the two function's behaviors will match. (Bug#3645) diff -r 0d8007720f35 -r e5035c6df58d lisp/ChangeLog --- a/lisp/ChangeLog Fri Oct 09 05:25:08 2009 +0000 +++ b/lisp/ChangeLog Fri Oct 09 05:54:57 2009 +0000 @@ -1,3 +1,9 @@ +2009-10-09 Karl Fogel + + * bookmark.el (bookmark-jump): Add new `display-func' parameter. + (bookmark-jump-other-window): Just invoke bookmark-jump with new + argument now, so the two function's behaviors will match. (Bug#3645) + 2009-10-08 Chong Yidong * cedet/ede/proj.el (project-make-dist, project-compile-project): diff -r 0d8007720f35 -r e5035c6df58d lisp/bookmark.el --- a/lisp/bookmark.el Fri Oct 09 05:25:08 2009 +0000 +++ b/lisp/bookmark.el Fri Oct 09 05:54:57 2009 +0000 @@ -989,7 +989,7 @@ ;;;###autoload -(defun bookmark-jump (bookmark) +(defun bookmark-jump (bookmark &optional display-func) "Jump to bookmark BOOKMARK (a point in some file). You may have a problem using this function if the value of variable `bookmark-alist' is nil. If that happens, you need to load in some @@ -1002,27 +1002,27 @@ of the old one in the permanent bookmark record. BOOKMARK may be a bookmark name (a string) or a bookmark record, but -the latter is usually only used by programmatic callers." +the latter is usually only used by programmatic callers. + +If DISPLAY-FUNC is non-nil, it is a function to invoke to display the +bookmark. It defaults to `switch-to-buffer'; a typical other value +would be, e.g., `switch-to-buffer-other-window'." (interactive (list (bookmark-completing-read "Jump to bookmark" bookmark-current-bookmark))) (unless bookmark (error "No bookmark specified")) (bookmark-maybe-historicize-string bookmark) - (bookmark--jump-via bookmark 'switch-to-buffer)) + (bookmark--jump-via bookmark (or display-func 'switch-to-buffer))) ;;;###autoload (defun bookmark-jump-other-window (bookmark) "Jump to BOOKMARK in another window. See `bookmark-jump' for more." (interactive - (let ((bkm (bookmark-completing-read "Jump to bookmark (in another window)" - bookmark-current-bookmark))) - (if (> emacs-major-version 21) - (list bkm) bkm))) - (when bookmark - (bookmark-maybe-historicize-string bookmark) - (bookmark--jump-via bookmark 'switch-to-buffer-other-window))) + (list (bookmark-completing-read "Jump to bookmark (in another window)" + bookmark-current-bookmark))) + (bookmark-jump bookmark 'switch-to-buffer-other-window)) (defun bookmark-jump-noselect (bookmark)