# HG changeset patch # User Katsumi Yamaoka # Date 1284077311 0 # Node ID ef15e8533a1cc75ce3a3f0c76f9afc2d07d1d6cd # Parent f70d39f7b8fdfd8a0587e32d8ac8c30ed34330ad Remove pop3-movemail and rename pop3-streaming-movemail to pop3-movemail. diff -r f70d39f7b8fd -r ef15e8533a1c lisp/gnus/ChangeLog --- a/lisp/gnus/ChangeLog Fri Sep 10 00:07:33 2010 +0000 +++ b/lisp/gnus/ChangeLog Fri Sep 10 00:08:31 2010 +0000 @@ -1,5 +1,10 @@ 2010-09-09 Lars Magne Ingebrigtsen + * mail-source.el (mail-source-fetch-pop): Use pop3-movemail again. + + * pop3.el (pop3-movemail): Removed. + (pop3-streaming-movemail): Renamed to pop3-movemail. + * gnus-html.el (gnus-html-wash-tags): Refactor out the image bit, and don't restrict end-tag searches to the end of the line. diff -r f70d39f7b8fd -r ef15e8533a1c lisp/gnus/mail-source.el --- a/lisp/gnus/mail-source.el Fri Sep 10 00:07:33 2010 +0000 +++ b/lisp/gnus/mail-source.el Fri Sep 10 00:08:31 2010 +0000 @@ -34,7 +34,7 @@ (require 'cl) (require 'imap)) (autoload 'auth-source-user-or-password "auth-source") -(autoload 'pop3-streaming-movemail "pop3") +(autoload 'pop3-movemail "pop3") (autoload 'pop3-get-message-count "pop3") (autoload 'nnheader-cancel-timer "nnheader") (require 'mm-util) @@ -839,11 +839,9 @@ (if (eq authentication 'apop) 'apop 'pass)) (pop3-stream-type stream)) (if (or debug-on-quit debug-on-error) - (save-excursion (pop3-streaming-movemail - mail-source-crash-box)) + (save-excursion (pop3-movemail mail-source-crash-box)) (condition-case err - (save-excursion (pop3-streaming-movemail - mail-source-crash-box)) + (save-excursion (pop3-movemail mail-source-crash-box)) (error ;; We nix out the password in case the error ;; was because of a wrong password being given. diff -r f70d39f7b8fd -r ef15e8533a1c lisp/gnus/pop3.el --- a/lisp/gnus/pop3.el Fri Sep 10 00:07:33 2010 +0000 +++ b/lisp/gnus/pop3.el Fri Sep 10 00:08:31 2010 +0000 @@ -129,7 +129,8 @@ (truncate pop3-read-timeout)) 1000)))))) -(defun pop3-streaming-movemail (file) +;;;###autoload +(defun pop3-movemail (file) "Transfer contents of a maildrop to the specified FILE. Use streaming commands." (let* ((process (pop3-open-server pop3-mailhost pop3-port)) @@ -227,44 +228,6 @@ (pop3-pass process)) (t (error "Invalid POP3 authentication scheme"))))) -(defun pop3-movemail (&optional crashbox) - "Transfer contents of a maildrop to the specified CRASHBOX." - (or crashbox (setq crashbox (expand-file-name "~/.crashbox"))) - (let* ((process (pop3-open-server pop3-mailhost pop3-port)) - (crashbuf (get-buffer-create " *pop3-retr*")) - (n 1) - message-count - message-sizes) - (pop3-logon process) - (setq message-count (car (pop3-stat process))) - (when (> message-count 0) - (setq message-sizes (pop3-list process))) - (unwind-protect - (while (<= n message-count) - (message "Retrieving message %d of %d from %s... (%.1fk)" - n message-count pop3-mailhost - (/ (cdr (assoc n message-sizes)) - 1024.0)) - (pop3-retr process n crashbuf) - (save-excursion - (set-buffer crashbuf) - (let ((coding-system-for-write 'binary)) - (write-region (point-min) (point-max) crashbox t 'nomesg)) - (set-buffer (process-buffer process)) - (erase-buffer)) - (unless pop3-leave-mail-on-server - (pop3-dele process n)) - (setq n (+ 1 n)) - (pop3-accept-process-output process)) - (when (and pop3-leave-mail-on-server - (> n 1)) - (message "pop3.el doesn't support UIDL. Setting `pop3-leave-mail-on-server' -to %s might not give the result you'd expect." pop3-leave-mail-on-server) - (sit-for 1)) - (pop3-quit process)) - (kill-buffer crashbuf)) - t) - (defun pop3-get-message-count () "Return the number of messages in the maildrop." (let* ((process (pop3-open-server pop3-mailhost pop3-port))