# HG changeset patch # User Richard M. Stallman # Date 893369747 0 # Node ID efa1c31f068c67cb231397aebd40573c4be8e598 # Parent 67d43c1789190658aa475ffc4169d66ff5e05cd9 (frame-name-alist): Remove this variable. (select-frame-by-name): Recompute the list of frames instead of saving it in a global variable. diff -r 67d43c178919 -r efa1c31f068c lisp/frame.el --- a/lisp/frame.el Thu Apr 23 22:07:20 1998 +0000 +++ b/lisp/frame.el Thu Apr 23 22:15:47 1998 +0000 @@ -541,24 +541,20 @@ falist)) (defvar frame-name-history nil) -(defvar frame-names-alist nil) (defun select-frame-by-name (name) "Select the frame whose name is NAME and raise it. If there is no frame by that name, signal an error." (interactive - (let (input default) - (setq frame-names-alist (make-frame-names-alist)) - (setq default (car (car frame-names-alist))) - (setq input - (completing-read - (format "Select Frame (default %s): " default) - frame-names-alist nil t nil 'frame-name-history)) + (let* ((frame-names-alist (make-frame-names-alist)) + (default (car (car frame-names-alist))) + (input (completing-read + (format "Select Frame (default %s): " default) + frame-names-alist nil t nil 'frame-name-history))) (if (= (length input) 0) (list default) (list input)))) - (or (interactive-p) - (setq frame-names-alist (make-frame-names-alist))) - (let ((frame (cdr (assoc name frame-names-alist)))) + (let* ((frame-names-alist (make-frame-names-alist)) + (frame (cdr (assoc name frame-names-alist)))) (or frame (error "There is no frame named `%s'" name)) (make-frame-visible frame)