# HG changeset patch # User Karl Fogel # Date 1262456008 18000 # Node ID f497db0aba00143f4549971136669050c765d1dd # Parent fecbb2b5a3553c147dee930de53470badfe748fc * lisp/bookmark.el (bookmark-bmenu-select, bookmark-bmenu-1-window, (bookmark-bmenu-2-window, bookmark-bmenu-this-window) (bookmark-bmenu-other-window, bookmark-bmenu-switch-other-window) (bookmark-bmenu-show-annotation, bookmark-bmenu-edit-annotation) (bookmark-bmenu-rename, bookmark-bmenu-locate) (bookmark-bmenu-relocate, bookmark-bmenu-goto-bookmark): Remove unnecessary calls to `bookmark-bmenu-ensure-position'. diff -r fecbb2b5a355 -r f497db0aba00 lisp/ChangeLog --- a/lisp/ChangeLog Sat Jan 02 19:33:54 2010 +0200 +++ b/lisp/ChangeLog Sat Jan 02 13:13:28 2010 -0500 @@ -1,3 +1,13 @@ +2010-01-02 Karl Fogel + + * bookmark.el (bookmark-bmenu-select, bookmark-bmenu-1-window, + (bookmark-bmenu-2-window, bookmark-bmenu-this-window) + (bookmark-bmenu-other-window, bookmark-bmenu-switch-other-window) + (bookmark-bmenu-show-annotation, bookmark-bmenu-edit-annotation) + (bookmark-bmenu-rename, bookmark-bmenu-locate) + (bookmark-bmenu-relocate, bookmark-bmenu-goto-bookmark): Remove + unnecessary calls to `bookmark-bmenu-ensure-position'. + 2010-01-02 Eli Zaretskii * emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Make diff -r fecbb2b5a355 -r f497db0aba00 lisp/bookmark.el --- a/lisp/bookmark.el Sat Jan 02 19:33:54 2010 +0200 +++ b/lisp/bookmark.el Sat Jan 02 13:13:28 2010 -0500 @@ -1763,7 +1763,6 @@ "Select this line's bookmark; also display bookmarks marked with `>'. You can mark bookmarks with the \\\\[bookmark-bmenu-mark] command." (interactive) - (bookmark-bmenu-ensure-position) (let ((bmrk (bookmark-bmenu-bookmark)) (menu (current-buffer)) (others ()) @@ -1840,7 +1839,6 @@ (defun bookmark-bmenu-1-window () "Select this line's bookmark, alone, in full frame." (interactive) - (bookmark-bmenu-ensure-position) (bookmark-jump (bookmark-bmenu-bookmark)) (bury-buffer (other-buffer)) (delete-other-windows)) @@ -1849,7 +1847,6 @@ (defun bookmark-bmenu-2-window () "Select this line's bookmark, with previous buffer in second window." (interactive) - (bookmark-bmenu-ensure-position) (let ((bmrk (bookmark-bmenu-bookmark)) (menu (current-buffer)) (pop-up-windows t)) @@ -1863,7 +1860,6 @@ (defun bookmark-bmenu-this-window () "Select this line's bookmark in this window." (interactive) - (bookmark-bmenu-ensure-position) (bookmark-jump (bookmark-bmenu-bookmark))) @@ -1871,7 +1867,6 @@ "Select this line's bookmark in other window, leaving bookmark menu visible." (interactive) (let ((bookmark (bookmark-bmenu-bookmark))) - (bookmark-bmenu-ensure-position) (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed? (bookmark--jump-via bookmark 'switch-to-buffer-other-window)))) @@ -1884,7 +1879,6 @@ (pop-up-windows t) same-window-buffer-names same-window-regexps) - (bookmark-bmenu-ensure-position) (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed? (bookmark--jump-via bookmark 'display-buffer)))) @@ -1901,7 +1895,6 @@ "Show the annotation for the current bookmark in another window." (interactive) (let ((bookmark (bookmark-bmenu-bookmark))) - (bookmark-bmenu-ensure-position) (bookmark-show-annotation bookmark))) @@ -1915,7 +1908,6 @@ "Edit the annotation for the current bookmark in another window." (interactive) (let ((bookmark (bookmark-bmenu-bookmark))) - (bookmark-bmenu-ensure-position) (bookmark-edit-annotation bookmark))) @@ -2001,7 +1993,6 @@ (defun bookmark-bmenu-rename () "Rename bookmark on current line. Prompts for a new name." (interactive) - (bookmark-bmenu-ensure-position) (let ((bmrk (bookmark-bmenu-bookmark)) (thispoint (point))) (bookmark-rename bmrk) @@ -2011,15 +2002,13 @@ (defun bookmark-bmenu-locate () "Display location of this bookmark. Displays in the minibuffer." (interactive) - (bookmark-bmenu-ensure-position) - (let ((bmrk (bookmark-bmenu-bookmark))) - (message "%s" (bookmark-location bmrk)))) + (let ((bmrk (bookmark-bmenu-bookmark))) + (message "%s" (bookmark-location bmrk)))) (defun bookmark-bmenu-relocate () "Change the file path of the bookmark on the current line, prompting with completion for the new path." (interactive) - (bookmark-bmenu-ensure-position) (let ((bmrk (bookmark-bmenu-bookmark)) (thispoint (point))) (bookmark-relocate bmrk) @@ -2084,7 +2073,6 @@ (defun bookmark-bmenu-goto-bookmark (name) "Move point to bookmark with name NAME." (goto-char (point-min)) - (bookmark-bmenu-ensure-position) (while (not (equal name (bookmark-bmenu-bookmark))) (forward-line 1)) (forward-line 0))