Mercurial > emacs
changeset 51318:0b5248964d32
Comment.
author | Dave Love <fx@gnu.org> |
---|---|
date | Thu, 29 May 2003 18:36:16 +0000 |
parents | 85280cb01eba |
children | d91863669383 |
files | src/alloc.c src/buffer.c |
diffstat | 2 files changed, 11 insertions(+), 4 deletions(-) [+] |
line wrap: on
line diff
--- a/src/alloc.c Thu May 29 18:18:10 2003 +0000 +++ b/src/alloc.c Thu May 29 18:36:16 2003 +0000 @@ -1393,7 +1393,13 @@ #ifdef DOUG_LEA_MALLOC /* Prevent mmap'ing the chunk. Lisp data may not be mmap'ed because mapped region contents are not preserved in - a dumped Emacs. */ + a dumped Emacs. + + In case you think of allowing it in a dumped Emacs at the + cost of not being able to re-dump, there's another reason: + mmap'ed data typically have an address towards the top of the + address space, which won't fit into an EMACS_INT (at least on + 32-bit systems with the current tagging scheme). --fx */ mallopt (M_MMAP_MAX, 0); #endif
--- a/src/buffer.c Thu May 29 18:18:10 2003 +0000 +++ b/src/buffer.c Thu May 29 18:36:16 2003 +0000 @@ -420,10 +420,11 @@ XSETBUFFER (buf, b); Vbuffer_alist = nconc2 (Vbuffer_alist, Fcons (Fcons (name, buf), Qnil)); - /* Fixme: Protect against errors, which would trigger infinite - regress? */ + /* An error in calling the function here (should someone redfine it) + can lead to infinite regress until you run out of stack. rms + says that's not worth protecting against. */ if (!NILP (Ffboundp (Qucs_set_table_for_input))) - /* buff is on buffer-alist, so no gcpro */ + /* buf is on buffer-alist, so no gcpro. */ call1 (Qucs_set_table_for_input, buf); return buf;