changeset 101160:0bcb0e9c72ca

(bug-reference-fontify): Check for non-nil `bug-reference-url-format' before putting an overlay property `bug-reference-url'. (bug-reference-mode, bug-reference-prog-mode): Don't check for `bug-reference-url-format'. Doc fix. (Bug#1744)
author Juri Linkov <juri@jurta.org>
date Wed, 14 Jan 2009 00:37:49 +0000
parents ec3f64163f9f
children 886c8ef66ffc
files lisp/progmodes/bug-reference.el
diffstat 1 files changed, 8 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/progmodes/bug-reference.el	Wed Jan 14 00:37:28 2009 +0000
+++ b/lisp/progmodes/bug-reference.el	Wed Jan 14 00:37:49 2009 +0000
@@ -85,9 +85,11 @@
 	  (let ((overlay (make-overlay (match-beginning 0) (match-end 0)
 				       nil t nil)))
 	    (overlay-put overlay 'category 'bug-reference)
-	    (overlay-put overlay 'bug-reference-url
-			 (format bug-reference-url-format
-				 (match-string-no-properties 1)))))))))
+	    ;; Don't put a link if format is undefined
+	    (when bug-reference-url-format
+	      (overlay-put overlay 'bug-reference-url
+			   (format bug-reference-url-format
+				   (match-string-no-properties 1))))))))))
 
 ;; Taken from button.el.
 (defun bug-reference-push-button (&optional pos use-mouse-action)
@@ -108,14 +110,12 @@
 
 ;;;###autoload
 (define-minor-mode bug-reference-mode
-  "Minor mode to buttonize bugzilla references in the current buffer.
-Requires `bug-reference-url-format' to be set in the buffer."
+  "Minor mode to buttonize bugzilla references in the current buffer."
   nil
   ""
   nil
   (if bug-reference-mode
-      (when bug-reference-url-format
-	(jit-lock-register #'bug-reference-fontify))
+      (jit-lock-register #'bug-reference-fontify)
     (jit-lock-unregister #'bug-reference-fontify)
     (save-restriction
       (widen)
@@ -128,8 +128,7 @@
   ""
   nil
   (if bug-reference-prog-mode
-      (when bug-reference-url-format
-	(jit-lock-register #'bug-reference-fontify))
+      (jit-lock-register #'bug-reference-fontify)
     (jit-lock-unregister #'bug-reference-fontify)
     (save-restriction
       (widen)