changeset 94546:11b8f709e661

(highlight-changes-mode): Removed references to hooks that no longer exist. Because define-minor-mode is used the hook highlight-changes-mode-hook exists and can do what both the old hooks used to do. The documentation at the top of the file was updated to demonstrate this. (highlight-changes-mode): Remove commented out call to a hook function that is no longer there. (hilit-chg-set): Remove running of highlight-changes-enable-hook.
author Juanma Barranquero <lekktu@gmail.com>
date Fri, 02 May 2008 08:50:25 +0000
parents d2fdb9cc1cc8
children 607b4fd9f3bc
files lisp/hilit-chg.el
diffstat 1 files changed, 15 insertions(+), 27 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/hilit-chg.el	Fri May 02 08:38:57 2008 +0000
+++ b/lisp/hilit-chg.el	Fri May 02 08:50:25 2008 +0000
@@ -62,24 +62,17 @@
 ;; You can automatically rotate faces when the buffer is saved;
 ;; see function `highlight-changes-rotate-faces' for how to do this.
 
-;; There are two hooks used by `highlight-changes-mode':
-;; `highlight-changes-enable-hook'  - is run when Highlight Changes mode
-;;				    is enabled for a buffer.
-;; `highlight-changes-disable-hook' - is run when Highlight Changes mode
-;;				    is disabled for a buffer.
-
+;; The hook `highlight-changes-mode-hook' is called when
+;; Highlight Changes mode is turned on or off.
+;; When it called, variable `highlight-changes-mode' has been updated
+;; to the new value.
+;;
 ;; Example usage:
-;; (defun my-highlight-changes-enable-hook ()
-;;   (add-hook 'write-file-functions 'highlight-changes-rotate-faces nil t)
-;; )
-;;
-;; (defun my-highlight-changes-disable-hook ()
-;;   (remove-hook 'write-file-functions 'highlight-changes-rotate-faces t)
-;; )
-;;
-;; (add-hook 'highlight-changes-enable-hook 'my-highlight-changes-enable-hook)
-;; (add-hook 'highlight-changes-disable-hook
-;;		'my-highlight-changes-disable-hook)
+;; (defun my-highlight-changes-mode-hook ()
+;;   (if highlight-changes-mode
+;;       (add-hook 'write-file-functions 'highlight-changes-rotate-faces nil t)
+;;     (remove-hook 'write-file-functions 'highlight-changes-rotate-faces t)
+;;     ))
 
 
 ;;           Automatically enabling Highlight Changes mode
@@ -175,7 +168,9 @@
 ;;   previous active/passive aspect of highlight-changes-mode.
 ;; - Removed highlight-changes-toggle-hook
 ;; - Put back eval-and-compile inadvertently dropped
-
+;; May 2008
+;; - Removed highlight-changes-disable-hook and highlight-changes-enable-hook
+;;   because highlight-changes-mode-hook can do both.
 
 ;;; Code:
 
@@ -353,11 +348,7 @@
 through	various faces.
 \\[highlight-compare-with-file] - mark text as changed by comparing this
 buffer with the contents of a file
-\\[highlight-compare-buffers] highlights differences between two buffers.
-
-Hook variables:
-`highlight-changes-enable-hook': called when enabling Highlight Changes mode.
-`highlight-changes-disable-hook': called when disabling Highlight Changes mode."
+\\[highlight-compare-buffers] highlights differences between two buffers."
   nil			;; init-value
   hilit-chg-string	;; lighter
   nil			;; keymap
@@ -372,8 +363,6 @@
 	    (setq highlight-changes-mode (not highlight-changes-mode)))
 	(if highlight-changes-mode
 	    ;; it is being turned on
-	    ;; the hook has been moved into hilit-chg-set
-	    ;; (run-hooks 'highlight-changes-enable-hook))
 	    (hilit-chg-set)
 	  ;; mode is turned off
 	  (hilit-chg-clear)))
@@ -634,8 +623,7 @@
   (setq highlight-changes-visible-mode highlight-changes-visibility-initial-state)
   (hilit-chg-update)
   (force-mode-line-update)
-  (add-hook 'after-change-functions 'hilit-chg-set-face-on-change nil t)
-  (run-hooks 'highlight-changes-enable-hook))
+  (add-hook 'after-change-functions 'hilit-chg-set-face-on-change nil t))
 
 (defun hilit-chg-clear ()
   "Remove Highlight Changes mode for this buffer.