Mercurial > emacs
changeset 92746:26e567ab8830
(display-buffer-other-frame): Eliminate problematic code.
author | Stefan Monnier <monnier@iro.umontreal.ca> |
---|---|
date | Tue, 11 Mar 2008 20:48:57 +0000 |
parents | 871ad7e118ff |
children | 98f0d29f01c5 |
files | lisp/ChangeLog lisp/files.el |
diffstat | 2 files changed, 14 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/lisp/ChangeLog Tue Mar 11 17:44:39 2008 +0000 +++ b/lisp/ChangeLog Tue Mar 11 20:48:57 2008 +0000 @@ -1,5 +1,7 @@ 2008-03-11 Stefan Monnier <monnier@iro.umontreal.ca> + * files.el (display-buffer-other-frame): Eliminate problematic code. + * menu-bar.el (menu-bar-update-buffers-maxbuf): Remove. (menu-bar-select-buffer): Remove. (menu-bar-select-frame): Make non-interactive and take a frame arg.
--- a/lisp/files.el Tue Mar 11 17:44:39 2008 +0000 +++ b/lisp/files.el Tue Mar 11 20:48:57 2008 +0000 @@ -1078,9 +1078,18 @@ (old-window (selected-window)) new-window) (setq new-window (display-buffer buffer t)) - (lower-frame (window-frame new-window)) - (make-frame-invisible (window-frame old-window)) - (make-frame-visible (window-frame old-window)))) + ;; This may have been here in order to prevent the new frame from hiding + ;; the old frame. But it does more harm than good. + ;; Maybe we should call `raise-window' on the old-frame instead? --Stef + ;;(lower-frame (window-frame new-window)) + + ;; This may have been here in order to make sure the old-frame gets the + ;; focus. But not only can it cause an annoying flicker, with some + ;; window-managers it just makes the window invisible, with no easy + ;; way to recover it. --Stef + ;;(make-frame-invisible (window-frame old-window)) + ;;(make-frame-visible (window-frame old-window)) + )) (defvar find-file-default nil "Used within `find-file-read-args'.")