Mercurial > emacs
changeset 78613:340dd924a553
(byte-compile-log-file, byte-recompile-directory, byte-compile-file)
(byte-compile-from-buffer): Use with-current-buffer.
| author | Stefan Monnier <monnier@iro.umontreal.ca> |
|---|---|
| date | Wed, 22 Aug 2007 15:51:13 +0000 |
| parents | 6afa3ea6e4da |
| children | 036719d86e2c |
| files | lisp/ChangeLog lisp/emacs-lisp/bytecomp.el |
| diffstat | 2 files changed, 13 insertions(+), 13 deletions(-) [+] |
line wrap: on
line diff
--- a/lisp/ChangeLog Wed Aug 22 15:43:46 2007 +0000 +++ b/lisp/ChangeLog Wed Aug 22 15:51:13 2007 +0000 @@ -1,5 +1,9 @@ 2007-08-22 Stefan Monnier <monnier@iro.umontreal.ca> + * emacs-lisp/bytecomp.el (byte-compile-log-file) + (byte-recompile-directory, byte-compile-file) + (byte-compile-from-buffer): Use with-current-buffer. + * simple.el (text-invisible-p): Rename from line-move-invisible-p. (line-move-invisible-p): Keep as an obsolete alias, just to be safe. (line-move-1, line-move-finish, line-move-to-column)
--- a/lisp/emacs-lisp/bytecomp.el Wed Aug 22 15:43:46 2007 +0000 +++ b/lisp/emacs-lisp/bytecomp.el Wed Aug 22 15:51:13 2007 +0000 @@ -1008,8 +1008,7 @@ (defun byte-compile-log-file () (and (not (equal byte-compile-current-file byte-compile-last-logged-file)) (not noninteractive) - (save-excursion - (set-buffer (get-buffer-create "*Compile-Log*")) + (with-current-buffer (get-buffer-create "*Compile-Log*") (goto-char (point-max)) (let* ((inhibit-read-only t) (dir (and byte-compile-current-file @@ -1545,8 +1544,7 @@ nil (save-some-buffers) (force-mode-line-update)) - (save-current-buffer - (set-buffer (get-buffer-create "*Compile-Log*")) + (with-current-buffer (get-buffer-create "*Compile-Log*") (setq default-directory (expand-file-name directory)) ;; compilation-mode copies value of default-directory. (unless (eq major-mode 'compilation-mode) @@ -1648,7 +1646,7 @@ (let ((b (get-file-buffer (expand-file-name filename)))) (if (and b (buffer-modified-p b) (y-or-n-p (format "Save buffer %s first? " (buffer-name b)))) - (save-excursion (set-buffer b) (save-buffer))))) + (with-current-buffer b (save-buffer))))) ;; Force logging of the file name for each file compiled. (setq byte-compile-last-logged-file nil) @@ -1658,9 +1656,8 @@ byte-compile-dest-file) (setq target-file (byte-compile-dest-file filename)) (setq byte-compile-dest-file target-file) - (save-excursion - (setq input-buffer (get-buffer-create " *Compiler Input*")) - (set-buffer input-buffer) + (with-current-buffer + (setq input-buffer (get-buffer-create " *Compiler Input*")) (erase-buffer) (setq buffer-file-coding-system nil) ;; Always compile an Emacs Lisp file as multibyte @@ -1830,9 +1827,8 @@ ;; byte-compile-warnings)) ) (byte-compile-close-variables - (save-excursion - (setq outbuffer - (set-buffer (get-buffer-create " *Compiler Output*"))) + (with-current-buffer + (setq outbuffer (get-buffer-create " *Compiler Output*")) (set-buffer-multibyte t) (erase-buffer) ;; (emacs-lisp-mode) @@ -1846,8 +1842,7 @@ (setq overwrite-mode 'overwrite-mode-binary)) (displaying-byte-compile-warnings (and filename (byte-compile-insert-header filename inbuffer outbuffer)) - (save-excursion - (set-buffer inbuffer) + (with-current-buffer inbuffer (goto-char 1) ;; Should we always do this? When calling multiple files, it ;; would be useful to delay this warning until all have been @@ -2036,6 +2031,7 @@ ;; We need to examine byte-compile-dynamic-docstrings ;; in the input buffer (now current), not in the output buffer. (let ((dynamic-docstrings byte-compile-dynamic-docstrings)) + ;; FIXME: What's up with those set-buffers&prog1 thingy? --Stef (set-buffer (prog1 (current-buffer) (set-buffer outbuffer)