Mercurial > emacs

changeset 94572:3bdffe280ad3

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Remove logentry primitive from backend API.
author Eric S. Raymond <esr@snark.thyrsus.com>
date Sat, 03 May 2008 07:39:17 +0000
parents 61cca370b8f5
children ce09c5078ae7
files lisp/ChangeLog lisp/vc-dispatcher.el lisp/vc-git.el lisp/vc-hg.el lisp/vc-sccs.el lisp/vc.el
diffstat 6 files changed, 9 insertions(+), 28 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/ChangeLog	Sat May 03 07:06:34 2008 +0000
+++ b/lisp/ChangeLog	Sat May 03 07:39:17 2008 +0000
@@ -3,7 +3,12 @@
 	* vc-dispatcher.el: New file, separates out the UI and command 
 	execution machinery from VCS-specific logic left in vc.el.  The
 	separation is not yet completely clean, but it's a good start.
-	* vc.el: This file is about 1700 lines shorter now.
+	* vc.el: This file is about 1700 lines shorter now.  Obsolete 
+	logentry-check is removed from the backend API.
+	* vc-sccs.el: Obsolete vc-sccs-logentry-check removed.  This was
+	was the only implementation of the logentry-check method, and
+	it guarded against a log length limit that has probably been
+	obsolete for 15 years (!).
 
 2008-05-02  Sam Steingold  <sds@gnu.org>
 
--- a/lisp/vc-dispatcher.el	Sat May 03 07:06:34 2008 +0000
+++ b/lisp/vc-dispatcher.el	Sat May 03 07:39:17 2008 +0000
@@ -138,10 +138,8 @@
             (insert s)
             (set-marker (process-mark p) (point))))))))
 
-(defun vc-setup-buffer (&optional buf)
-  "Prepare BUF for executing a VC command and make it current.
-BUF defaults to \"*vc*\", can be a string and will be created if necessary."
-  (unless buf (setq buf "*vc*"))
+(defun vc-setup-buffer (buf)
+  "Prepare BUF for executing a slave command and make it current."
   (let ((camefrom (current-buffer))
 	(olddir default-directory))
     (set-buffer (get-buffer-create buf))
@@ -501,7 +499,6 @@
 	(message "%s  Type C-c C-c when done" msg)
       (vc-finish-logentry (eq comment t)))))
 
-;; FIXME: Reference to vc-call-backend should go.
 (defun vc-finish-logentry (&optional nocomment)
   "Complete the operation implied by the current log entry.
 Use the contents of the current buffer as a check-in or registration
@@ -510,10 +507,6 @@
   (interactive)
   ;; Check and record the comment, if any.
   (unless nocomment
-    ;; Comment too long?
-    (vc-call-backend (or (when vc-log-fileset (vc-backend vc-log-fileset))
-			 (vc-responsible-backend default-directory))
-		     'logentry-check)
     (run-hooks 'vc-logentry-check-hook))
   ;; Sync parent buffer in case the user modified it while editing the comment.
   ;; But not if it is a vc-dired buffer.
@@ -557,7 +550,6 @@
       (vc-dir-move-to-goal-column))
     (run-hooks after-hook 'vc-finish-logentry-hook)))
 
-
 ;; The VC directory major mode.  Coopt Dired for this.
 ;; All VC commands get mapped into logical equivalents.
 
--- a/lisp/vc-git.el	Sat May 03 07:06:34 2008 +0000
+++ b/lisp/vc-git.el	Sat May 03 07:39:17 2008 +0000
@@ -83,7 +83,6 @@
 ;; - log-view-mode ()				   OK
 ;; - show-log-entry (revision)			   OK
 ;; - wash-log (file)				   COULD BE SUPPORTED
-;; - logentry-check ()				   NOT NEEDED
 ;; - comment-history (file)			   ??
 ;; - update-changelog (files)			   COULD BE SUPPORTED
 ;; * diff (file &optional rev1 rev2 buffer)	   OK
--- a/lisp/vc-hg.el	Sat May 03 07:06:34 2008 +0000
+++ b/lisp/vc-hg.el	Sat May 03 07:39:17 2008 +0000
@@ -72,7 +72,6 @@
 ;; - log-view-mode ()                          OK
 ;; - show-log-entry (revision)                  NOT NEEDED, DEFAULT IS GOOD
 ;; - wash-log (file)                           ??
-;; - logentry-check ()                         NOT NEEDED
 ;; - comment-history (file)                    NOT NEEDED
 ;; - update-changelog (files)                  NOT NEEDED
 ;; * diff (files &optional rev1 rev2 buffer)   OK
--- a/lisp/vc-sccs.el	Sat May 03 07:06:34 2008 +0000
+++ b/lisp/vc-sccs.el	Sat May 03 07:39:17 2008 +0000
@@ -332,12 +332,6 @@
   ;; FIXME: not implemented for SCCS
   nil)
 
-(defun vc-sccs-logentry-check ()
-  "Check that the log entry in the current buffer is acceptable for SCCS."
-  (when (>= (buffer-size) 512)
-    (goto-char 512)
-    (error "Log must be less than 512 characters; point is now at pos 512")))
-
 (defun vc-sccs-diff (files &optional oldvers newvers buffer)
   "Get a difference report using SCCS between two filesets."
   (setq oldvers (vc-sccs-lookup-triple (car files) oldvers))
--- a/lisp/vc.el	Sat May 03 07:06:34 2008 +0000
+++ b/lisp/vc.el	Sat May 03 07:39:17 2008 +0000
@@ -401,13 +401,6 @@
 ;;
 ;;   Remove all non-comment information from the output of print-log.
 ;;
-;; - logentry-check ()
-;;
-;;   If defined, this function is run to find out whether the user
-;;   entered a valid log entry for check-in.  The log entry is in the
-;;   current buffer, and if it is not a valid one, the function should
-;;   throw an error.
-;;
 ;; - comment-history (file)
 ;;
 ;;   Return a string containing all log entries that were made for FILE.
@@ -823,7 +816,7 @@
   :group 'vc)
 
 (defcustom vc-logentry-check-hook nil
-  "Normal hook run by `vc-backend-logentry-check'.
+  "Normal hook run by `vc-finish-logentry'.
 Use this to impose your own rules on the entry in addition to any the
 version control backend imposes itself."
   :type 'hook
@@ -2733,7 +2726,6 @@
   (with-current-buffer (find-file-noselect new)
     (vc-register)))
 
-(defalias 'vc-default-logentry-check 'ignore)
 (defalias 'vc-default-check-headers 'ignore)
 
 (defun vc-default-log-view-mode (backend) (log-view-mode))