changeset 70907:4f3bfa0df084

(Bindat Functions): Say "unibyte string" explicitly for `bindat-unpack' and `bindat-pack' descriptions. (Bindat Examples): Don't call `string-make-unibyte' in example.
author Thien-Thi Nguyen <ttn@gnuvola.org>
date Thu, 25 May 2006 09:01:43 +0000
parents 6d78b8af6fc8
children 2db87b8b31b0
files lispref/processes.texi
diffstat 1 files changed, 14 insertions(+), 18 deletions(-) [+]
line wrap: on
line diff
--- a/lispref/processes.texi	Thu May 25 08:51:31 2006 +0000
+++ b/lispref/processes.texi	Thu May 25 09:01:43 2006 +0000
@@ -2245,7 +2245,8 @@
 alist representing unpacked field data.
 
 @defun bindat-unpack spec raw-data &optional pos
-This function unpacks data from the byte array @code{raw-data}
+This function unpacks data from the unibyte string or byte
+array @code{raw-data}
 according to @var{spec}.  Normally this starts unpacking at the
 beginning of the byte array, but if @var{pos} is non-@code{nil}, it
 specifies a zero-based starting position to use instead.
@@ -2277,13 +2278,9 @@
 This function returns a byte array packed according to @var{spec} from
 the data in the alist @var{struct}.  Normally it creates and fills a
 new byte array starting at the beginning.  However, if @var{raw-data}
-is non-@code{nil}, it specifies a pre-allocated string or vector to
+is non-@code{nil}, it specifies a pre-allocated unibyte string or vector to
 pack into.  If @var{pos} is non-@code{nil}, it specifies the starting
 offset for packing into @code{raw-data}.
-
-@c ??? Isn't this a bug?  Shouldn't it always be unibyte?
-Note: The result is a multibyte string; use @code{string-make-unibyte}
-on it to make it unibyte if necessary.
 @end defun
 
 @defun bindat-ip-to-string ip
@@ -2367,18 +2364,17 @@
     (with-temp-buffer
       (set-buffer-multibyte nil)
       (insert
-       (string-make-unibyte
-        (bindat-pack
-         fcookie-index-spec
-         `((:version . 2)
-           (:count . ,count)
-           (:longest . ,max)
-           (:shortest . ,min)
-           (:flags . 0)
-           (:delim . ,delim)
-           (:offset . ,(mapcar (lambda (o)
-                                 (list (cons :foo o)))
-                               (nreverse offsets)))))))
+       (bindat-pack
+        fcookie-index-spec
+        `((:version . 2)
+          (:count . ,count)
+          (:longest . ,max)
+          (:shortest . ,min)
+          (:flags . 0)
+          (:delim . ,delim)
+          (:offset . ,(mapcar (lambda (o)
+                                (list (cons :foo o)))
+                              (nreverse offsets))))))
       (let ((coding-system-for-write 'raw-text-unix))
         (write-file (or index (concat cookies ".dat")))))))
 @end lisp