Mercurial > emacs
changeset 61434:6d07c19816b9
(mm-string-to-multibyte): New function.
(mm-detect-coding-region): Typo.
| author | Stefan Monnier <monnier@iro.umontreal.ca> |
|---|---|
| date | Sun, 10 Apr 2005 19:04:09 +0000 |
| parents | 74a256d5f3ec |
| children | e23c9743cccb |
| files | lisp/gnus/ChangeLog lisp/gnus/mm-util.el |
| diffstat | 2 files changed, 26 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/lisp/gnus/ChangeLog Sun Apr 10 19:02:24 2005 +0000 +++ b/lisp/gnus/ChangeLog Sun Apr 10 19:04:09 2005 +0000 @@ -1,3 +1,8 @@ +2005-04-10 Stefan Monnier <monnier@iro.umontreal.ca> + + * mm-util.el (mm-string-to-multibyte): New function. + (mm-detect-coding-region): Typo. + 2005-04-06 Katsumi Yamaoka <yamaoka@jpl.org> * mm-util.el (mm-coding-system-p): Don't return binary for the nil
--- a/lisp/gnus/mm-util.el Sun Apr 10 19:02:24 2005 +0000 +++ b/lisp/gnus/mm-util.el Sun Apr 10 19:04:09 2005 +0000 @@ -72,7 +72,26 @@ string))) (string-as-unibyte . identity) (string-make-unibyte . identity) + ;; string-as-multibyte often doesn't really do what you think it does. + ;; Example: + ;; (aref (string-as-multibyte "\201") 0) -> 129 (aka ?\201) + ;; (aref (string-as-multibyte "\300") 0) -> 192 (aka ?\300) + ;; (aref (string-as-multibyte "\300\201") 0) -> 192 (aka ?\300) + ;; (aref (string-as-multibyte "\300\201") 1) -> 129 (aka ?\201) + ;; but + ;; (aref (string-as-multibyte "\201\300") 0) -> 2240 + ;; (aref (string-as-multibyte "\201\300") 1) -> <error> + ;; Better use string-to-multibyte or encode-coding-string. + ;; If you really need string-as-multibyte somewhere it's usually + ;; because you're using the internal emacs-mule representation (maybe + ;; because you're using string-as-unibyte somewhere), which is + ;; generally a problem in itself. + ;; Here is an approximate equivalence table to help think about it: + ;; (string-as-multibyte s) ~= (decode-coding-string s 'emacs-mule) + ;; (string-to-multibyte s) ~= (decode-coding-string s 'binary) + ;; (string-make-multibyte s) ~= (decode-coding-string s locale-coding-system) (string-as-multibyte . identity) + (string-to-multibyte . mm-string-as-multibyte) (multibyte-string-p . ignore) ;; It is not a MIME function, but some MIME functions use it. (make-temp-file . (lambda (prefix &optional dir-flag) @@ -938,7 +957,7 @@ (defun mm-detect-coding-region (start end) "Like `detect-coding-region' except returning the best one." (let ((coding-systems - (detect-coding-region (point) (point-max)))) + (detect-coding-region start end))) (or (car-safe coding-systems) coding-systems))) (defun mm-detect-coding-region (start end) @@ -962,5 +981,5 @@ (provide 'mm-util) -;;; arch-tag: 94dc5388-825d-4fd1-bfa5-2100aa351238 +;; arch-tag: 94dc5388-825d-4fd1-bfa5-2100aa351238 ;;; mm-util.el ends here