Mercurial > emacs
changeset 110197:727cc5d69397
pop3.el (pop3-write-to-file): Don't output messages when saving; mail-source.el (mail-source-delete-crash-box): Really only check the incoming files once in a while; nnml.el (nnml-save-nov): Message around nnml-save-nov so that the culprit is more visible; pop3.el (pop3-send-streaming-command): Off-by-one error on the request loop (for debugging purposes) removed.
| author | Katsumi Yamaoka <yamaoka@jpl.org> |
|---|---|
| date | Sun, 05 Sep 2010 01:18:05 +0000 |
| parents | fcc33f6790e5 |
| children | 8867a7812454 |
| files | lisp/gnus/ChangeLog lisp/gnus/mail-source.el lisp/gnus/nnml.el lisp/gnus/pop3.el |
| diffstat | 4 files changed, 25 insertions(+), 17 deletions(-) [+] |
line wrap: on
line diff
--- a/lisp/gnus/ChangeLog Sun Sep 05 01:12:51 2010 +0000 +++ b/lisp/gnus/ChangeLog Sun Sep 05 01:18:05 2010 +0000 @@ -1,5 +1,11 @@ 2010-09-04 Lars Magne Ingebrigtsen <larsi@gnus.org> + * nnml.el (nnml-save-nov): Message around nnml-save-nov so that the + culprit is more visible. + + * mail-source.el (mail-source-delete-crash-box): Really only check the + incoming files once in a while. + * pop3.el (pop3-streaming-movemail): Always close the pop3 connection. * mail-source.el (mail-source-delete-crash-box): Only check the
--- a/lisp/gnus/mail-source.el Sun Sep 05 01:12:51 2010 +0000 +++ b/lisp/gnus/mail-source.el Sun Sep 05 01:18:05 2010 +0000 @@ -637,20 +637,20 @@ (> (time-to-seconds (time-since mail-source-incoming-last-checked-time)) (* 24 60 60))) - (setq mail-source-incoming-last-checked-time (current-time))) - (let ((incoming - (mm-make-temp-file - (expand-file-name - mail-source-incoming-file-prefix - mail-source-directory)))) - (unless (file-exists-p (file-name-directory incoming)) - (make-directory (file-name-directory incoming) t)) - (rename-file mail-source-crash-box incoming t) - ;; remove old incoming files? - (when (natnump mail-source-delete-incoming) - (mail-source-delete-old-incoming - mail-source-delete-incoming - mail-source-delete-old-incoming-confirm)))))) + (setq mail-source-incoming-last-checked-time (current-time)) + (let ((incoming + (mm-make-temp-file + (expand-file-name + mail-source-incoming-file-prefix + mail-source-directory)))) + (unless (file-exists-p (file-name-directory incoming)) + (make-directory (file-name-directory incoming) t)) + (rename-file mail-source-crash-box incoming t) + ;; remove old incoming files? + (when (natnump mail-source-delete-incoming) + (mail-source-delete-old-incoming + mail-source-delete-incoming + mail-source-delete-old-incoming-confirm))))))) (defun mail-source-movemail (from to) "Move FROM to TO using movemail."
--- a/lisp/gnus/nnml.el Sun Sep 05 01:12:51 2010 +0000 +++ b/lisp/gnus/nnml.el Sun Sep 05 01:18:05 2010 +0000 @@ -824,6 +824,7 @@ buffer))) (defun nnml-save-nov () + (message "nnml saving nov...") (save-excursion (while nnml-nov-buffer-alist (when (buffer-name (cdar nnml-nov-buffer-alist)) @@ -833,7 +834,8 @@ nnml-nov-buffer-file-name nil 'nomesg)) (set-buffer-modified-p nil) (kill-buffer (current-buffer))) - (setq nnml-nov-buffer-alist (cdr nnml-nov-buffer-alist))))) + (setq nnml-nov-buffer-alist (cdr nnml-nov-buffer-alist)))) + (message "nnml saving nov...done")) ;;;###autoload (defun nnml-generate-nov-databases (&optional server)
--- a/lisp/gnus/pop3.el Sun Sep 05 01:12:51 2010 +0000 +++ b/lisp/gnus/pop3.el Sun Sep 05 01:18:05 2010 +0000 @@ -150,7 +150,7 @@ (defun pop3-send-streaming-command (process command count total-size) (erase-buffer) (let ((i 1)) - (while (>= (1+ count) i) + (while (>= count i) (process-send-string process (format "%s %d\r\n" command i)) ;; Only do 100 messages at a time to avoid pipe stalls. (when (zerop (% i 100)) @@ -197,7 +197,7 @@ ;; delete it. (when (eolp) (delete-char 1)) - (write-region (point-min) (point-max) file))))) + (write-region (point-min) (point-max) file nil 'nomesg))))) (defun pop3-number-of-responses (endp) (let ((responses 0))