changeset 23331:8e860ff326de

(make-help-screen): Keep HELP-TEXT in a separate function definition, not in the help command FNAME. Replace %THIS-KEY% with the key sequence that ran FNAME.
author Richard M. Stallman <rms@gnu.org>
date Sun, 27 Sep 1998 21:17:00 +0000
parents 3f2ab6f2bb5c
children d0403c974cac
files lisp/help-macro.el
diffstat 1 files changed, 15 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/help-macro.el	Sun Sep 27 12:37:22 1998 +0000
+++ b/lisp/help-macro.el	Sun Sep 27 21:17:00 1998 +0000
@@ -84,16 +84,21 @@
 When invoked, FNAME shows HELP-LINE and reads a command using HELPED-MAP.
 If the command is the help character, FNAME displays HELP-TEXT
 and continues trying to read a command using HELPED-MAP.
+If HELP-TEXT contains the sequence `%THIS-KEY%', that is replaced
+with the key sequence that invoked FNAME.
 When FNAME finally does get a command, it executes that command
 and then returns."
-  (` (defun (, fname) ()
-	   (, help-text)
+ (let ((doc-fn (intern (concat (symbol-name fname) "-doc"))))
+  `(progn
+    (defun ,doc-fn () ,help-text)
+    (defun ,fname ()
+	   "Help command."
 	   (interactive)
 	   (let ((line-prompt
-		  (substitute-command-keys (, help-line))))
+		  (substitute-command-keys ,help-line)))
 	     (if three-step-help
 		 (message "%s" line-prompt))
-	     (let* ((help-screen (documentation (quote (, fname))))
+	     (let* ((help-screen (documentation (quote ,doc-fn)))
 		    ;; We bind overriding-local-map for very small
 		    ;; sections, *excluding* where we switch buffers
 		    ;; and where we execute the chosen help command.
@@ -101,9 +106,13 @@
 		    (minor-mode-map-alist nil)
 		    (prev-frame (selected-frame))
 		    config new-frame key char)
+	       (if (string-match "%THIS-KEY%" help-screen)
+		   (setq help-screen
+			 (replace-match (key-description (substring (this-command-keys) 0 -1))
+					t t help-screen)))
 	       (unwind-protect
 		   (progn
-		     (setcdr local-map (, helped-map))
+		     (setcdr local-map ,helped-map)
 		     (define-key local-map [t] 'undefined)
 		     ;; Make the scroll bar keep working normally.
 		     (define-key local-map [vertical-scroll-bar]
@@ -182,7 +191,7 @@
 		 (if new-frame (iconify-frame new-frame))
 		 (if config
 		     (set-window-configuration config))))))
-     ))
+     )))
 
 ;;; help-macro.el