Mercurial > emacs
changeset 94522:a69dcc2c42ae
Remove some XXX comments no longer needed.
| author | Eric S. Raymond <esr@snark.thyrsus.com> |
|---|---|
| date | Thu, 01 May 2008 19:28:56 +0000 |
| parents | 2a61c5f918a5 |
| children | 10e2a368efb0 |
| files | lisp/vc-bzr.el lisp/vc-cvs.el lisp/vc-hg.el lisp/vc-rcs.el lisp/vc-sccs.el lisp/vc.el |
| diffstat | 6 files changed, 8 insertions(+), 19 deletions(-) [+] |
line wrap: on
line diff
--- a/lisp/vc-bzr.el Thu May 01 19:13:16 2008 +0000 +++ b/lisp/vc-bzr.el Thu May 01 19:28:56 2008 +0000 @@ -593,10 +593,9 @@ ;; files are up-to-date unless they appear in the `bzr ;; status' output below (vc-file-setprop file 'vc-state 'up-to-date) - ;; XXX: is this correct? what happens if one - ;; mixes different SCMs in the same dir? - ;; Anyway, we're looking at the output of `bzr ls --versioned', - ;; so we know these files are registered with Bzr. + ;; Anyway, we're looking at the output of `bzr ls + ;; --versioned', so we know these files are registered with + ;; Bzr. (vc-file-setprop file 'vc-backend 'Bzr)))) ;; `bzr status' reports on added/modified/renamed and unknown/ignored files (setq at-start t) @@ -694,11 +693,8 @@ (forward-line)) (funcall update-function result))) -;; XXX Experimental function for the vc-dired replacement. -;; XXX This probably needs some further refinement and testing. (defun vc-bzr-dir-status (dir update-function) "Return a list of conses (file . state) for DIR." - ;; XXX: Is this the right command to use? (vc-bzr-command "status" (current-buffer) 'async dir "-v" "-S") (vc-exec-after `(vc-bzr-after-dir-status (quote ,update-function))))
--- a/lisp/vc-cvs.el Thu May 01 19:13:16 2008 +0000 +++ b/lisp/vc-cvs.el Thu May 01 19:28:56 2008 +0000 @@ -857,10 +857,9 @@ (vc-cvs-parse-entry file t)))) (forward-line 1)))) -;; XXX Experimental function for the vc-dired replacement. (defun vc-cvs-after-dir-status (update-function) ;; Heavily inspired by vc-cvs-parse-status. AKA a quick hack. - ;; It needs a lot of testing. + ;; This needs a lot of testing. (let ((status nil) (status-str nil) (file nil)
--- a/lisp/vc-hg.el Thu May 01 19:13:16 2008 +0000 +++ b/lisp/vc-hg.el Thu May 01 19:28:56 2008 +0000 @@ -457,8 +457,6 @@ ;;; Hg specific functionality. -;; XXX This functionality is experimental/work in progress. It might -;; change without notice. (defvar vc-hg-extra-menu-map (let ((map (make-sparse-keymap))) (define-key map [incoming] '(menu-item "Show incoming" vc-hg-incoming))
--- a/lisp/vc-rcs.el Thu May 01 19:13:16 2008 +0000 +++ b/lisp/vc-rcs.el Thu May 01 19:28:56 2008 +0000 @@ -182,10 +182,9 @@ (vc-rcs-state file)))) (vc-rcs-state file))))) -;; XXX Experimental function for the vc-dired replacement. (defun vc-rcs-dir-status (dir update-function) - ;; XXX: quick hack, there should be a better way to do this, - ;; but it's not worse than vc-dired :-). + ;; Doing individual vc-state calls is painful but tgere + ;; is no better way in RCS-land. (let ((flist (vc-expand-dirs (list dir))) (result nil)) (dolist (file flist)
--- a/lisp/vc-sccs.el Thu May 01 19:13:16 2008 +0000 +++ b/lisp/vc-sccs.el Thu May 01 19:28:56 2008 +0000 @@ -156,10 +156,9 @@ (vc-sccs-state file)))) (vc-sccs-state file))) -;; XXX Experimental function for the vc-dired replacement. (defun vc-sccs-dir-status (dir update-function) - ;; XXX: quick hack, there should be a better way to do this, - ;; but it's not worse than vc-dired :-). + ;; Doing loys of undividual VC-state calls is painful, but + ;; there is no better option in SCCS-land. (let ((flist (vc-expand-dirs (list dir))) (result nil)) (dolist (file flist)
--- a/lisp/vc.el Thu May 01 19:13:16 2008 +0000 +++ b/lisp/vc.el Thu May 01 19:28:56 2008 +0000 @@ -3432,8 +3432,6 @@ (interactive) (vc-dir-mark-unmark 'vc-dir-mark-file)) - -;; XXX: Should this take the region into consideration? (defun vc-dir-mark-all-files (arg) "Mark all files with the same state as the current one. With a prefix argument mark all files.