changeset 87626:a918e56d9947

Remember: If region is visible, use it as initial text.
author Michael Olson <mwolson@gnu.org>
date Tue, 08 Jan 2008 01:33:08 +0000
parents f1e7931e86ce
children 7d4c20334bd7
files lisp/ChangeLog lisp/textmodes/remember.el
diffstat 2 files changed, 18 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/ChangeLog	Mon Jan 07 18:24:12 2008 +0000
+++ b/lisp/ChangeLog	Tue Jan 08 01:33:08 2008 +0000
@@ -1,3 +1,15 @@
+2008-01-08  Michael Olson  <mwolson@gnu.org>
+
+	* textmodes/remember.el (remember-region): Fix typo in docstring.
+
+2008-01-08  Lennart Borgman  <lennart.borgman.073@student.lu.se>
+
+	* textmodes/remember.el (remember): If there is a visible region
+	[that is, the mark is active and transient mark mode is enabled]
+	then use this region for the initial contents of the *Remember*
+	buffer.  Use `region-beginning' and `region-end' instead of
+	`point' and `mark'.
+
 2008-01-07  Dan Nicolaescu  <dann@ics.uci.edu>
 
 	* vc-hg.el (vc-hg-dir-state, vc-hg-dir-status): Pass the dir
--- a/lisp/textmodes/remember.el	Mon Jan 07 18:24:12 2008 +0000
+++ b/lisp/textmodes/remember.el	Tue Jan 08 01:33:08 2008 +0000
@@ -273,10 +273,12 @@
 INITIAL is the text to initially place in the *Remember* buffer,
 or nil to bring up a blank *Remember* buffer.
 
-With a prefix, use the region as INITIAL."
+With a prefix or a visible region, use the region as INITIAL."
   (interactive
-   (list (when current-prefix-arg
-           (buffer-substring (point) (mark)))))
+   (list (when (or current-prefix-arg
+                   (and mark-active
+                        transient-mark-mode))
+           (buffer-substring (region-beginning) (region-end)))))
   (funcall (if remember-in-new-frame
                #'frame-configuration-to-register
              #'window-configuration-to-register) remember-register)
@@ -422,7 +424,7 @@
 (defun remember-region (&optional beg end)
   "Remember the data from BEG to END.
 It is called from within the *Remember* buffer to save the text
-that was entered,
+that was entered.
 
 If BEG and END are nil, the entire buffer will be remembered.