changeset 76774:a98404fc2d91

(PC-do-completion-end): New variable. (partial-completion-mode) <choose-completion-string-functions>: Use PC-do-completion-end in the non-minibuffer case to replace the correct amount of text. (PC-do-completion): Set PC-do-completion-end for c-c-s-f. (PC-lisp-complete-symbol): Give marker the after-insertion type, to deal with improvements inserted after point.
author Glenn Morris <rgm@gnu.org>
date Wed, 28 Mar 2007 03:28:49 +0000
parents e0a9f7f7486a
children 3891e219df10
files lisp/complete.el
diffstat 1 files changed, 12 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/complete.el	Wed Mar 28 03:26:26 2007 +0000
+++ b/lisp/complete.el	Wed Mar 28 03:28:49 2007 +0000
@@ -187,6 +187,9 @@
 
 	   (define-key global-map [remap lisp-complete-symbol]	'PC-lisp-complete-symbol)))))
 
+(defvar PC-do-completion-end nil
+  "Internal variable used by `PC-do-completion'.")
+
 ;;;###autoload
 (define-minor-mode partial-completion-mode
   "Toggle Partial Completion mode.
@@ -239,7 +242,9 @@
    (if partial-completion-mode 'add-hook 'remove-hook)
    'choose-completion-string-functions
    (lambda (choice buffer mini-p base-size)
-     (if mini-p (goto-char (point-max)))
+     (if mini-p (goto-char (point-max))
+       ;; Need a similar hack for the non-minibuffer-case -- gm.
+       (if PC-do-completion-end (goto-char PC-do-completion-end)))
      nil))
   ;; Build the env-completion and mapping table.
   (when (and partial-completion-mode (null PC-env-vars-alist))
@@ -759,9 +764,13 @@
                           ;; completion gets confused trying to figure out
                           ;; how much to replace, so we tell it explicitly
                           ;; (ie, the number of chars in the buffer before beg).
+                          ;;
+                          ;; Note that choose-completion-string-functions
+                          ;; plays around with point.
                           (setq completion-base-size (if dirname
                                                          dirlength
-                                                       (- beg prompt-end))))))
+                                                       (- beg prompt-end))
+                                PC-do-completion-end end))))
 		  (PC-temp-minibuffer-message " [Next char not unique]"))
 		nil)))))
 
@@ -869,6 +878,7 @@
     (if (equal last-command 'PC-lisp-complete-symbol)
         (PC-do-completion nil beg PC-lisp-complete-end)
       (setq PC-lisp-complete-end (point-marker))
+      (set-marker-insertion-type PC-lisp-complete-end t)
       (PC-do-completion nil beg end))))
 
 (defun PC-complete-as-file-name ()